Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Conversation

nurjinjafar
Copy link
Contributor

@nurjinjafar nurjinjafar commented Aug 29, 2023

We https://github.com/nordeck are currently implementing the knock rooms behind the feature flag feature_ask_to_join (introduced in #11182).

This pull request introduces the deny mask for requests.

Epic: element-hq/element-web#18655

Relates to
#11404
matrix-org/matrix-js-sdk#3673
#11353
matrix-org/matrix-js-sdk#3647
#11248
#11182
element-hq/element-web#25923

Screens

Screenshot 2023-08-29 at 14 15 48

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Here's what your changelog entry will look like:

✨ Features
Introduce Deny access request mask on Ask-to-join rooms (#11479). Contributed by @nurjinjafar.


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Charly Nguyen and others added 16 commits August 23, 2023 16:47
…into nurjinjafar/notify_users_about_denied_access_on_ask_to_join_rooms
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Fix avatar initial centering in pills for bubbles

* Express user info avatar size in pixes

* fix link pill icon

* Fix snapshot test
@nurjinjafar nurjinjafar requested a review from a team as a code owner August 29, 2023 12:20
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Aug 29, 2023
@nurjinjafar nurjinjafar marked this pull request as draft August 29, 2023 12:32
…into nurjinjafar/notify_users_about_denied_access_on_ask_to_join_rooms
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants