Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 66 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,70 @@
from typing import List, Optional


class Cargo:
def __init__(self, weight: int) -> None:
self.weight = weight

# write your code here

class BaseRobot:
def __init__(self,
name: str,
weight: int,
coords: Optional[List[int]] = None) -> None:
self.name = name
self.weight = weight
self.coords = coords or [0, 0]

def go_forward(self, step: int = 1) -> None:
self.coords[1] += step

def go_back(self, step: int = 1) -> None:
self.coords[1] -= step

def go_right(self, step: int = 1) -> None:
self.coords[0] += step

def go_left(self, step: int = 1) -> None:
self.coords[0] -= step

def get_info(self) -> str:
return f"Robot: {self.name}, Weight: {self.weight}"


class FlyingRobot(BaseRobot):

def __init__(self,
name: str,
weight: int,
coords: Optional[List[int]] = None) -> None:
if coords is None:
coords = [0, 0, 0]
elif len(coords) == 2:
coords.append(0)
super().__init__(name, weight, coords[:2])
self.coords = coords
Comment on lines +39 to +45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling coords parameter in the FlyingRobot class: You're adjusting coords to handle 2D or 3D coordinates, but the way you pass them to BaseRobot isn't consistent.


def go_up(self, step: int = 1) -> None:
self.coords[2] += step

def go_down(self, step: int = 1) -> None:
self.coords[2] -= step


class DeliveryDrone(FlyingRobot):
def __init__(self,
name: str,
weight: int,
coords: Optional[List[int]] = None,
max_load_weight: int = 0,
current_load: Cargo = None) -> None:
super().__init__(name, weight, coords)
self.max_load_weight = max_load_weight
self.current_load = current_load

def hook_load(self, cargo: Cargo) -> None:
if self.current_load is None and cargo.weight <= self.max_load_weight:
self.current_load = cargo

def unhook_load(self) -> None:
self.current_load = None
Comment on lines +54 to +70

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handling the max_load_weight and current_load in DeliveryDrone: The current_load is a Cargo object but the default value should be None. Also, Cargo is passed correctly, but handling load conditions can be a bit more explicit.

Loading