solution #1240
Open
solution #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshmygel
reviewed
Oct 7, 2024
app/main.py
Outdated
Comment on lines
31
to
36
| if coords is None: | ||
| coords = [0, 0, 0] | ||
| elif len(coords) == 2: | ||
| coords.append(0) | ||
| elif len(coords) == 3: | ||
| pass |
mshmygel
approved these changes
Oct 7, 2024
mshmygel
approved these changes
Oct 7, 2024
AnyoneClown
suggested changes
Oct 9, 2024
app/main.py
Outdated
| def __init__(self, name: str, weight: int, coords: list = None) -> None: | ||
| self.name = name | ||
| self.weight = weight | ||
| self.coords = coords if coords is not None else [0, 0] |
app/main.py
Outdated
| # write your code here | ||
|
|
||
| class BaseRobot: | ||
| def __init__(self, name: str, weight: int, coords: list = None) -> None: |
There was a problem hiding this comment.
Add more descriptive annotation for coords. Check other annotation too
app/main.py
Outdated
Comment on lines
31
to
36
| if coords is None: | ||
| coords = [0, 0, 0] | ||
| elif len(coords) == 2: | ||
| coords.append(0) | ||
| elif len(coords) == 3: | ||
| pass |
app/main.py
Outdated
Comment on lines
48
to
51
| def __init__(self, name: str, | ||
| weight: int, coords: list = None, | ||
| max_load_weight: int = 0, | ||
| current_load: Cargo = None) -> None: |
There was a problem hiding this comment.
Start every argument from a new line(start name from a new line)
Arsen-hrynevych
approved these changes
Oct 14, 2024
Comment on lines
+39
to
+45
| coords: Optional[List[int]] = None) -> None: | ||
| if coords is None: | ||
| coords = [0, 0, 0] | ||
| elif len(coords) == 2: | ||
| coords.append(0) | ||
| super().__init__(name, weight, coords[:2]) | ||
| self.coords = coords |
There was a problem hiding this comment.
Handling coords parameter in the FlyingRobot class: You're adjusting coords to handle 2D or 3D coordinates, but the way you pass them to BaseRobot isn't consistent.
Comment on lines
+54
to
+70
| class DeliveryDrone(FlyingRobot): | ||
| def __init__(self, | ||
| name: str, | ||
| weight: int, | ||
| coords: Optional[List[int]] = None, | ||
| max_load_weight: int = 0, | ||
| current_load: Cargo = None) -> None: | ||
| super().__init__(name, weight, coords) | ||
| self.max_load_weight = max_load_weight | ||
| self.current_load = current_load | ||
|
|
||
| def hook_load(self, cargo: Cargo) -> None: | ||
| if self.current_load is None and cargo.weight <= self.max_load_weight: | ||
| self.current_load = cargo | ||
|
|
||
| def unhook_load(self) -> None: | ||
| self.current_load = None |
There was a problem hiding this comment.
Handling the max_load_weight and current_load in DeliveryDrone: The current_load is a Cargo object but the default value should be None. Also, Cargo is passed correctly, but handling load conditions can be a bit more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.