Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added app/cinema.db3
Binary file not shown.
26 changes: 13 additions & 13 deletions app/main.py
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
# from models import Actor
# from managers import ActorManager
#
# if __name__ == "__main__":
# Actor.objects = ActorManager()
#
# Actor.objects.create(first_name="Emma", last_name="Watson")
# Actor.objects.create(first_name="Daniel", last_name="Radclife")
# print(Actor.objects.all())
# Actor.objects.update(2, "Daniel", "Radcliffe")
# print(Actor.objects.all())
# Actor.objects.delete(1)
# print(Actor.objects.all())
from models import Actor
from managers import ActorManager

if __name__ == "__main__":
Actor.objects = ActorManager()

Actor.objects.create(first_name_="Emma", last_name_="Watson")
Actor.objects.create(first_name_="Daniel", last_name_="Radclife")
print(Actor.objects.all())
Actor.objects.update(2, "Daniel", "Radcliffe")
print(Actor.objects.all())
Actor.objects.delete(4)
print(Actor.objects.all())
46 changes: 46 additions & 0 deletions app/managers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import sqlite3

from app.models import Actor


class ActorManager:
def __init__(self) -> None:
self._connection = sqlite3.connect("cinema.db3")
self.table_name = "actors"

def all(self) -> list:
actor_cursor = self._connection.execute(
f"SELECT * FROM {self.table_name}"
)

return [Actor(*row) for row in actor_cursor]

def create(self, first_name_: str, last_name_: str) -> None:
self._connection.execute(
f"INSERT INTO {self.table_name} (first_name, last_name)"
f"VALUES (?, ?)",
(first_name_, last_name_)
)
self._connection.commit()

def update(
self,
id_to_upd: int,
new_first_name: str,
new_last_name: str
) -> None:
self._connection.execute(
f"UPDATE {self.table_name} "
"SET first_name = ?, last_name = ? "
"Where id = ?",
(new_first_name, new_last_name, id_to_upd)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think id_to_upd is a very good abbreviation. It only saves you two characters anyway. So why don't you rename the variable into id_to_update

)
self._connection.commit()

def delete(self, id_to_del: int) -> None:
self._connection.execute(
f"DELETE FROM {self.table_name} "
"WHERE id = ?",
(id_to_del,)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think id_to_del is a very good abbreviation. It only saves you two characters anyway. So why don't you rename the variable into id_to_delete

)
self._connection.commit()
8 changes: 8 additions & 0 deletions app/models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
from dataclasses import dataclass


@dataclass
class Actor:
id: int
first_name: str
last_name: str
Loading