Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution #487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solution #487

wants to merge 2 commits into from

Conversation

CaCtUs1k
Copy link

@CaCtUs1k CaCtUs1k commented Sep 6, 2023

No description provided.

obohatov
obohatov approved these changes Sep 7, 2023
View reviewed changes
Copy link

@obohatov obohatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the database file should have been sent

Sofbog
Sofbog suggested changes Sep 7, 2023
View reviewed changes
Copy link

@Sofbog Sofbog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

app/managers.py Outdated
self._connection.execute(
f"DELETE FROM {self.table_name} "
"WHERE id = ?",
(id_to_del,)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think id_to_del is a very good abbreviation. It only saves you two characters anyway. So why don't you rename the variable into id_to_delete

app/managers.py Outdated
f"UPDATE {self.table_name} "
"SET first_name = ?, last_name = ? "
"Where id = ?",
(new_first_name, new_last_name, id_to_upd)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think id_to_upd is a very good abbreviation. It only saves you two characters anyway. So why don't you rename the variable into id_to_update

@CaCtUs1k CaCtUs1k requested a review from Sofbog September 7, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obohatov obohatov obohatov approved these changes

@Serhii-Leonenko Serhii-Leonenko Serhii-Leonenko approved these changes

@Sofbog Sofbog Awaiting requested review from Sofbog

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CaCtUs1k @Sofbog @obohatov @Serhii-Leonenko