Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw solution #2153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

public class Bulldozer extends Machine {
public void doWork() {
System.out.println("Bulldozer started its engine and began to work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate what type of 'Machine' is working right now. It's better to specify that it's a 'Bulldozer' to make the message more informative.

}

@Override
public void stopWork() {
System.out.println("Bulldozer turned off its engine and stopped working.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the doWork() method, the message in stopWork() should be more informative and indicate that it's a 'Bulldozer' that has stopped working.

}
}
12 changes: 12 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package core.basesyntax;

public class Excavator extends Machine {
public void doWork() {
System.out.println("Excavator started its engine and began to work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should be more informative and indicate that it is an 'Excavator' that has started working. For example: "Excavator is working."

}

@Override
public void stopWork() {
System.out.println("Excavator turned off its engine and stopped working.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop message should also be more informative and specific to the 'Excavator'. For example: "Excavator has stopped working."

}
}
7 changes: 7 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package core.basesyntax;

public abstract class Machine {
public abstract void doWork();

public abstract void stopWork();
}
11 changes: 11 additions & 0 deletions src/main/java/core/basesyntax/MainApp.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
package core.basesyntax;

public class MainApp {
public static void main(String[] args) {
Machine[] machines = {
new Truck(),
new Bulldozer(),
new Excavator()
};

for (Machine machine : machines) {
machine.doWork();
machine.stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck started its engine and began to work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message 'Truck started its engine and began to work.' could be more informative by specifying that it's a Truck that is working. Consider rephrasing it to include the type of Machine, for example: 'Truck is working.'

}

@Override
public void stopWork() {
System.out.println("Truck turned off its engine and stopped working.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message 'Truck turned off its engine and stopped working.' could be more informative. It's recommended to rephrase it to clearly indicate the type of Machine, for example: 'Truck has stopped working.'

}
}
Loading