Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw solution #2153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

katrienkraska
Copy link

No description provided.

… and public abstract void stopWork().

Create classes Truck, Bulldozer, and Excavator that will inherit from Machine.
… and public abstract void stopWork().

Create classes Truck, Bulldozer, and Excavator that will inherit from Machine.
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the Machine class as an abstract entity and ensuring that polymorphism is used effectively through the MainApp.java. Keep in mind the suggestions about making the log messages more informative by specifying the machine type. This will enhance clarity and maintainability. Keep up the good work, and remember to address the feedback in future iterations for continued improvement! 👍🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨


public class Bulldozer extends Machine {
public void doWork() {
System.out.println("Bulldozer started its engine and began to work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate what type of 'Machine' is working right now. It's better to specify that it's a 'Bulldozer' to make the message more informative.


@Override
public void stopWork() {
System.out.println("Bulldozer turned off its engine and stopped working.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the doWork() method, the message in stopWork() should be more informative and indicate that it's a 'Bulldozer' that has stopped working.


public class Excavator extends Machine {
public void doWork() {
System.out.println("Excavator started its engine and began to work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should be more informative and indicate that it is an 'Excavator' that has started working. For example: "Excavator is working."


@Override
public void stopWork() {
System.out.println("Excavator turned off its engine and stopped working.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop message should also be more informative and specific to the 'Excavator'. For example: "Excavator has stopped working."

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck started its engine and began to work.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message 'Truck started its engine and began to work.' could be more informative by specifying that it's a Truck that is working. Consider rephrasing it to include the type of Machine, for example: 'Truck is working.'


@Override
public void stopWork() {
System.out.println("Truck turned off its engine and stopped working.");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message 'Truck turned off its engine and stopped working.' could be more informative. It's recommended to rephrase it to clearly indicate the type of Machine, for example: 'Truck has stopped working.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants