Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The task is done! #2146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer started working!");
}

@Override
public void stopWork() {
System.out.println("Bulldozer stopped work!");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should be informative and indicate the type of Machine is working right now. Consider changing the message to match the format used in the doWork method, such as 'Bulldozer stopped working!'.

}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator started working!");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should be more informative and indicate that it is an 'Excavator' that is working. Consider specifying the type of machine in the message, for example: 'Excavator is working.'

}

@Override
public void stopWork() {
System.out.println("Excavator stopped work!");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stop message should be consistent with the start message. Consider changing it to 'Excavator stopped working.' to match the informative style.

}
}
9 changes: 9 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package core.basesyntax;

public abstract class Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

public abstract void doWork();

public abstract void stopWork();

}
8 changes: 7 additions & 1 deletion src/main/java/core/basesyntax/MainApp.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
package core.basesyntax;

public class MainApp {

public static void main(String[] args) {
Machine[] machines = {new Bulldozer(), new Excavator(), new Truck()};
for (Machine machine : machines) {
machine.doWork();
machine.stopWork();
}
}
}
14 changes: 14 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package core.basesyntax;

public class Truck extends Machine {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@Override
public void doWork() {
System.out.println("Truck started working!");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate what type of Machine is working right now Truck, Bulldozer or Excavator. Consider rephrasing it to something like 'Truck is doing its work.' to be more informative.

}

@Override
public void stopWork() {
System.out.println("Truck stopped work!");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message in stopWork should be more informative. For example, 'Truck has stopped working.' would be clearer.

}
}
Loading