The task is done! #2146
The task is done! #2146
Conversation
There was a problem hiding this comment.
Great job on your Pull Request! The Machine class is well-defined, and the MainApp class adheres to the task requirements. Just remember to keep your messages informative in the doWork and stopWork methods to enhance clarity. Keep up the excellent work! 👍💻
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Bulldozer stopped work!"); |
There was a problem hiding this comment.
The message should be informative and indicate the type of Machine is working right now. Consider changing the message to match the format used in the doWork method, such as 'Bulldozer stopped working!'.
| public class Excavator extends Machine { | ||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Excavator started working!"); |
There was a problem hiding this comment.
The message should be more informative and indicate that it is an 'Excavator' that is working. Consider specifying the type of machine in the message, for example: 'Excavator is working.'
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Excavator stopped work!"); |
There was a problem hiding this comment.
The stop message should be consistent with the start message. Consider changing it to 'Excavator stopped working.' to match the informative style.
|
|
||
| @Override | ||
| public void doWork() { | ||
| System.out.println("Truck started working!"); |
There was a problem hiding this comment.
The message should indicate what type of Machine is working right now Truck, Bulldozer or Excavator. Consider rephrasing it to something like 'Truck is doing its work.' to be more informative.
|
|
||
| @Override | ||
| public void stopWork() { | ||
| System.out.println("Truck stopped work!"); |
There was a problem hiding this comment.
Similarly, the message in stopWork should be more informative. For example, 'Truck has stopped working.' would be clearer.
| package core.basesyntax; | ||
|
|
||
| public abstract class Machine { | ||
|
|
| package core.basesyntax; | ||
|
|
||
| public class Truck extends Machine { | ||
|
|
No description provided.