Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HW done #2134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HW done #2134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f850ca
HW done
sergiikonov Sep 14, 2024
3705bf5
comments edited
sergiikonov Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Bulldozer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer starts work");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate the specific type of machine that is working. Consider including 'Bulldozer' in the message for clarity, e.g., 'Bulldozer is starting its work.'

}

@Override
public void stopWork() {
System.out.println("Bulldozer stopped working");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the stop message should clearly indicate that it's the 'Bulldozer' that stopped working. For example, 'Bulldozer has stopped working.'

}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Excavator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator starts work");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in the doWork method should be more informative. According to the checklist, it should indicate the type of Machine that is working. Consider rephrasing it to include the word 'Excavator' explicitly, for example, 'Excavator is doing its work.'

}

@Override
public void stopWork() {
System.out.println("Excavator stopped working");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message in the stopWork method should be more informative and indicate the specific type of Machine. You could change it to 'Excavator has stopped working.' to make it clearer.

}
}
7 changes: 7 additions & 0 deletions src/main/java/core/basesyntax/Machine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
package core.basesyntax;

public abstract class Machine {
public abstract void doWork();

public abstract void stopWork();
}
9 changes: 9 additions & 0 deletions src/main/java/core/basesyntax/MainApp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
package core.basesyntax;

public class MainApp {
public static void main(String[] args) {
Machine[] machines = { new Excavator(), new Bulldozer(), new Truck() };
for (Machine machine : machines) {
machine.doWork();
}

for (Machine machine : machines) {
machine.stopWork();
}
}
}
13 changes: 13 additions & 0 deletions src/main/java/core/basesyntax/Truck.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package core.basesyntax;

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck starts work");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message 'Truck starts work' could be more informative. According to the checklist, it should indicate what type of Machine is working, which is correct, but consider including more details about the work the Truck is doing.

}

@Override
public void stopWork() {
System.out.println("Truck stopped working");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message 'Truck stopped working' could provide more context about the state of the Truck when it stops working. More informative messages would improve the clarity of the code behavior.

}
}
Loading