Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW done #2134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HW done #2134

wants to merge 2 commits into from

Conversation

sergiikonov
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on your code! 🌟 It looks like you've followed the guidelines and implemented the necessary functionality effectively. Keep up the good work, and always aim to provide clear and informative messages in your methods for better readability and maintenance. Happy coding! 👍

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

public class Bulldozer extends Machine {
@Override
public void doWork() {
System.out.println("Bulldozer starts work");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message should indicate the specific type of machine that is working. Consider including 'Bulldozer' in the message for clarity, e.g., 'Bulldozer is starting its work.'


@Override
public void stopWork() {
System.out.println("Bulldozer stopped working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the stop message should clearly indicate that it's the 'Bulldozer' that stopped working. For example, 'Bulldozer has stopped working.'

public class Excavator extends Machine {
@Override
public void doWork() {
System.out.println("Excavator starts work");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message in the doWork method should be more informative. According to the checklist, it should indicate the type of Machine that is working. Consider rephrasing it to include the word 'Excavator' explicitly, for example, 'Excavator is doing its work.'


@Override
public void stopWork() {
System.out.println("Excavator stopped working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message in the stopWork method should be more informative and indicate the specific type of Machine. You could change it to 'Excavator has stopped working.' to make it clearer.

public class Truck extends Machine {
@Override
public void doWork() {
System.out.println("Truck starts work");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message 'Truck starts work' could be more informative. According to the checklist, it should indicate what type of Machine is working, which is correct, but consider including more details about the work the Truck is doing.


@Override
public void stopWork() {
System.out.println("Truck stopped working");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, the message 'Truck stopped working' could provide more context about the state of the Truck when it stops working. More informative messages would improve the clarity of the code behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants