Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto apply theme to mo.ui.data_explorer based on the notebook display theme #2233

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Auto apply theme to mo.ui.data_explorer based on the notebook display theme #2233

merged 2 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. Auto apply theme to mo.ui.data_explorer based on the notebook display… 

    … theme

Fixes #2228

Update `ConnectedDataExplorerComponent` to apply dark theme based on the current display theme.

* **Import `useTheme` hook:**
  - Import `useTheme` from `frontend/src/theme/useTheme.ts`.

* **Apply dark theme:**
  - Use the `useTheme` hook to get the current theme.
  - Apply the dark theme to the `VegaLite` component if the current theme is dark.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/marimo-team/marimo/issues/2228?shareId=XXXX-XXXX-XXXX-XXXX).
    @mscolnick
    mscolnick committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    56ef7b1 View commit details
    Browse the repository at this point in the history

  2. Update ConnectedDataExplorerComponent.tsx

    @mscolnick
    mscolnick authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c24e906 View commit details
    Browse the repository at this point in the history