Auto apply theme to mo.ui.data_explorer based on the notebook display theme #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… theme Fixes #2228 Update `ConnectedDataExplorerComponent` to apply dark theme based on the current display theme. * **Import `useTheme` hook:** - Import `useTheme` from `frontend/src/theme/useTheme.ts`. * **Apply dark theme:** - Use the `useTheme` hook to get the current theme. - Apply the dark theme to the `VegaLite` component if the current theme is dark. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/marimo-team/marimo/issues/2228?shareId=XXXX-XXXX-XXXX-XXXX).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
/marimo create-test-release |
|
🚀 Test release published. You may be able to view the changes at https://marimo.app?v=0.8.11-dev91884 |
akshayka
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2228
Update
ConnectedDataExplorerComponentto apply dark theme based on the current display theme.Import
useThemehook:useThemefromfrontend/src/theme/useTheme.ts.Apply dark theme:
useThemehook to get the current theme.VegaLitecomponent if the current theme is dark.For more details, open the Copilot Workspace session.