-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Traffic plugin #9
Changes from 41 commits
c668d1e
7fd48a7
2918d13
a152b6e
40d9c89
a0c9bb5
7705747
f91405c
4b40bfd
5df3231
9b67e32
7b69be8
860a970
cf8fb8f
4f3aa6a
543c321
d042115
94a48c0
40e110f
1bfac30
0afafb1
e1630d2
eb6e790
4b923d9
1b8af7b
082f207
8079053
ee348aa
bbad61a
8ab9926
2d3c1cc
e92db09
720bebf
b7851ad
569c9e7
5617295
b75e474
c55b5db
c3619bf
1fd4ed6
411fb28
79d2755
c51c5d0
e5f966d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,12 @@ | ||
.DS_Store | ||
|
||
*.framework | ||
*.build/* | ||
xcuserdata | ||
*.xccheckout | ||
*.moved-aside | ||
*.xcuserstate | ||
*.xcscmblueprint | ||
mapbox_access_token | ||
|
||
Carthage/ | ||
Pods | ||
*.xcworkspace |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
# Contributing | ||
|
||
We welcome contributions to Mapbox Plugins for iOS. In order to add a plugin, please open an issue outlining the plugin. This allow contributors to discuss the proposal and also ensure that there isn't already work being done on that feature. | ||
|
||
If you are interested in reporting a bug, please open an issue that includes steps to reproduce the issue. Suggestions for how to improve existing plugins are also welcome. | ||
|
||
|
||
# Code of conduct | ||
|
||
Everyone is invited to participate in Mapbox’s open source projects and public discussions: we want to create a welcoming and friendly environment. Harassment of participants or other unethical and unprofessional behavior will not be tolerated in our spaces. The [Contributor Covenant](http://contributor-covenant.org) applies to all projects under the Mapbox organization and we ask that you please read [the full text](http://contributor-covenant.org/version/1/2/0/). | ||
|
||
You can learn more about our open source philosophy on [mapbox.com](https://www.mapbox.com/about/open/). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
Copyright © 2017, Mapbox | ||
|
||
Permission to use, copy, modify, and/or distribute this software for any | ||
purpose with or without fee is hereby granted, provided that the above | ||
copyright notice and this permission notice appear in all copies. | ||
|
||
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES | ||
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF | ||
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR | ||
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES | ||
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN | ||
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF | ||
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
|
||
Pod::Spec.new do |s| | ||
|
||
# ――― Spec Metadata ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― # | ||
# | ||
|
||
s.name = "MapboxPlugins" | ||
s.version = "0.0.1" | ||
s.summary = "Experimental plugins to supercharge your maps." | ||
|
||
# This description is used to generate tags and improve search results. | ||
s.description = "Add plugins to your Mapbox basemaps. Each plugin is packaged as a subspec. At the moment, the following plugin is available: | ||
* “Traffic” adds traffic congestion layers to a map view. | ||
Mapbox Plugins require version 3.6 of the Mapbox iOS SDK or higher." | ||
s.homepage = "https://github.com/mapbox/mapbox-plugins-ios/" | ||
s.screenshot = 'https://github.com/mapbox/mapbox-plugins-ios/blob/master/TrafficPlugin/trafficplugin.gif' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will need to be a URL to a raw image, not its HTML description page. I think it’ll be: https://raw.githubusercontent.com/mapbox/mapbox-plugins-ios/master/TrafficPlugin/trafficplugin.gif There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oops, missed the previous feedback. Thanks! |
||
# ――― Spec License ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― # | ||
|
||
s.license = { :type => "ISC", :file => "LICENSE.md" } | ||
|
||
# ――― Author Metadata ――――――――――――――――――――――――――――――――――――――――――――――――――――――――― # | ||
|
||
s.author = { "Mapbox" => "[email protected]" } | ||
s.social_media_url = "https://twitter.com/mapbox" | ||
|
||
# ――― Platform Specifics ――――――――――――――――――――――――――――――――――――――――――――――――――――――― # | ||
# | ||
|
||
s.platform = :ios, "8.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Believe it or not, I think the code in PluginKit and Traffic would also compile just fine on macOS with the |
||
|
||
# ――― Source Location ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――― # | ||
|
||
s.source = { :git => "https://github.com/mapbox/mapbox-plugins-ios.git", :branch => "traffic-plugin" } | ||
|
||
s.module_name = 'MapboxPlugins' | ||
|
||
s.subspec 'PluginKit' do |core| | ||
core.source_files = 'PluginKit/*.h' | ||
core.dependency 'Mapbox-iOS-SDK' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should specify a minimum version of any dependency. v3.6 is a reasonable minimum, given that the traffic plugin uses the camera and style function syntaxes introduced in that version. |
||
end | ||
|
||
s.subspec 'Traffic' do |traffic| | ||
traffic.source_files = 'TrafficPlugin/*.{h,m}' | ||
traffic.dependency 'MapboxPlugins/PluginKit' | ||
end | ||
|
||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can specify trafficplugin.gif as
s.screenshots
, unless there’s a better screenshot to use here.s.screenshots
requires a URL to an image that exists on a server. So we can use the raw URL to the image on GitHub, but make sure to use a permalink, ideally with the tag in the URL (example).