[WIP] Traffic plugin #9

jmkiley · 2017-08-31T01:27:57Z

To Do:

Add method to add traffic layer above another layer.
Cleanup code.
~~- [ ] Carthage.~~
Read me/instructions for how to use.
Have others test out installation.

friedbunny · 2017-08-31T17:43:01Z

Initial notes as I tried out the demo app in the repo:

Need to carthage bootstrap.
Need to create mapbox_access_token.
mapbox-plugins-ios/Funhouse/Info.plist': The file “Info.plist” couldn’t be opened because there is no such file.
There is no scheme with the same name as the Funhouse target — it appears to be called MapboxPlugins.
The test app effectively has three names — TestApp, Funhouse, and MapboxPlugins.
If the traffic layer isn’t available until ~z10, we should make a note of that (otherwise folks will load the thing and think it’s not working).

jmkiley · 2017-08-31T18:17:53Z

TY! I missed a few things when I was renaming from Funhouse -> TestApp. Working on catching everything now.

friedbunny · 2017-08-31T18:58:33Z

.gitignore

@@ -5,6 +5,6 @@ xcuserdata
 *.moved-aside
 *.xcuserstate
 *.xcscmblueprint
-mapbox_access_token
+


Hrm, I think mapbox_access_token still needs to be ignored, it’s just that creating the file is a necessary step towards getting the demo app working.

jmkiley · 2017-08-31T19:32:12Z

@friedbunny found an issue where the Mapbox framework isn't visible when you install through CocoaPods. I am working on fixing that now.

jmkiley · 2017-08-31T20:54:34Z

I think I resolved the Module not found issue in 5302a40. I changed @import Mapbox; to #import <Mapbox-iOS-SDK/Mapbox/Mapbox.h>. 🤞

boundsj · 2017-08-31T20:59:32Z

TrafficPlugin/MBXTrafficPlugin.m

+
+// Default method to add traffic layers
+- (void)addToMapView:(MGLMapView *)mapView {
+    MGLSymbolStyleLayer *symbolLayer = [mapView.style layerWithIdentifier:@"poi-scalerank3"];


Noticing a warning from here in an application project that uses this branch. The result of the call to layerWithIdentifier needs to be cast to a MGLSymbolStyleLayer (if it safely can be) to avoid the warning.

jmkiley · 2017-08-31T21:19:52Z

Currently running into issues with using the Traffic Plugin in the TestApp, but it seems to be working via CocoaPods. Going to work on Carthage integration, then on fixing TestApp.

jmkiley · 2017-09-11T23:51:12Z

I think I've addressed most, if not all, of @friedbunny and @1ec5's feedback!

jmkiley · 2017-09-13T17:03:02Z

I think this is ready for re-review 😬

friedbunny · 2017-09-14T16:58:26Z

If you re-record trafficplugin.gif using v3.7.0 or master, the map styles will smoothly transition (instead of flashing and completely redrawing).

friedbunny

I see that we’ve git-ignored mapbox_access_token and the build folder and its products, but the files themselves should also be removed from this PR.

friedbunny · 2017-09-14T17:02:25Z

TrafficPlugin/TrafficPlugin.build/DerivedSources/TrafficPlugin_vers.c

@@ -0,0 +1,5 @@
+ extern const unsigned char TrafficPluginVersionString[];


De-commit the build folder.

friedbunny · 2017-09-14T17:03:12Z

TrafficPlugin/TrafficPlugin.framework.dSYM/Contents/Info.plist

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>


Delete build products, such as the framework and its dSYM.

friedbunny · 2017-09-14T17:08:01Z

.gitignore

@@ -1,10 +1,12 @@
 .DS_Store

+TrafficPlugin.framework
+TrafficPlugin.build


Perhaps make these more generic, so that future plugins can benefit.

friedbunny · 2017-09-14T17:20:53Z

MapboxPlugins.podspec

+  #  the deployment target. You can optionally include the target after the platform.
+  #
+
+  s.platform     = :ios, "10.0"


Unless there’s an insurmountable technical limitation, this project should support the same platforms as the maps SDK itself (which works back to iOS 8).

The deployment target for this project is also currently set to iOS 10.

friedbunny · 2017-09-14T17:27:03Z

README.md

+
+Test out Mapbox Plugins in the TestApp.
+
+1. Run `carthage bootstrap` to install the Mapbox iOS SDK.


Is this the current flow to use the test app? This PR checks in a Podfile and Podfile.lock, which should be deleted if we’re recommending Carthage for this purpose.

If Carthage is the current flow, there should be a Cartfile.resolved.

friedbunny · 2017-09-14T17:34:26Z

README.md

+
+Test out Mapbox Plugins in the TestApp.
+
+1. Run `carthage bootstrap` to install the Mapbox iOS SDK.


If we’re using CocoaPods for the test app, this is what happens:

$ pod install Analyzing dependencies Downloading dependencies Using Mapbox-iOS-SDK (3.6.2) Generating Pods project Integrating client project Sending stats Pod installation complete! There is 1 dependency from the Podfile and 1 total pod installed. [!] Automatically assigning platform ios with version 10.0 on target PluginKit because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`. [!] Automatically assigning platform ios with version 10.0 on target TestApp because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`. [!] Automatically assigning platform ios with version 10.0 on target TrafficPlugin because no platform was specified. Please specify a platform for this target in your Podfile. See `https://guides.cocoapods.org/syntax/podfile.html#platform`. [!] The Podfile contains framework or static library targets, for which the Podfile does not contain host targets (targets which embed the framework). If this project is for doing framework development, you can ignore this message. Otherwise, add a target to the Podfile that embeds these frameworks to make this message go away (e.g. a test target). [!] The `PluginKit [Debug]` target overrides the `OTHER_LDFLAGS` build setting defined in `Pods/Target Support Files/Pods-PluginKit/Pods-PluginKit.debug.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target. [!] The `PluginKit [Release]` target overrides the `OTHER_LDFLAGS` build setting defined in `Pods/Target Support Files/Pods-PluginKit/Pods-PluginKit.release.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target. [!] The `TrafficPlugin [Debug]` target overrides the `FRAMEWORK_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-TrafficPlugin/Pods-TrafficPlugin.debug.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target. [!] The `TrafficPlugin [Release]` target overrides the `FRAMEWORK_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-TrafficPlugin/Pods-TrafficPlugin.release.xcconfig'. This can lead to problems with the CocoaPods installation - Use the `$(inherited)` flag, or - Remove the build settings from the target.

And then TestApp doesn’t compile:

Thanks! Think I fixed this 🙇‍♀️ Working on cleaning up the other files now.

1ec5 · 2017-09-14T23:50:23Z

MapboxPlugins.podspec

+  s.description  = "Add plugins to your Mapbox basemaps. Mapbox Plugins allow you to add a traffic layer to your maps."
+
+  s.homepage     = "https://github.com/mapbox/mapbox-plugins-ios/"
+  # s.screenshots  = "www.example.com/screenshots_1.gif", "www.example.com/screenshots_2.gif"


We can use trafficplugin.gif here for now.

1ec5 · 2017-09-14T23:52:52Z

MapboxPlugins.podspec

+  #   * Try to keep it short, snappy and to the point.
+  #   * Write the description between the DESC delimiters below.
+  #   * Finally, don't worry about the indent, CocoaPods strips it!
+  s.description  = "Add plugins to your Mapbox basemaps. Mapbox Plugins allow you to add a traffic layer to your maps."


Add plugins to your Mapbox basemaps. Each plugin is packaged as a subspec. At the moment, the following plugin is available: * “Traffic” adds traffic congestion layers to a map view.

1ec5 · 2017-09-14T23:56:32Z

MapboxPlugins.podspec

+  #  the deployment target. You can optionally include the target after the platform.
+  #
+
+  s.platform     = :ios, "8.0"


Believe it or not, I think the code in PluginKit and Traffic would also compile just fine on macOS with the Mapbox-macOS-SDK pod. Not sure if there’s a way to specify different dependencies based on the platform, though.

1ec5 · 2017-09-14T23:59:13Z

TrafficPlugin/MBXTrafficPlugin.m

+// Default method to add traffic layers
+- (void)addToMapView:(MGLMapView *)mapView {
+    for (MGLStyleLayer *layer in mapView.style.layers.reverseObjectEnumerator) {
+        if (![layer isKindOfClass:[MGLSymbolStyleLayer class]]) {


I think the algorithm outlined in #9 (comment) would be more robust. Among the things that would go under the traffic lines with this implementation are route lines and other shape sources. Traffic lines are so closely associated with roads that we should try to keep them as close as possible to the road layers in the layer stack.

1ec5 · 2017-09-15T00:02:08Z

TrafficPlugin/MBXTrafficPlugin.m

+                                                                                                        blue:0
+                                                                                                       alpha:1]]
+                                          };
+        _trafficColor = [MGLStyleValue valueWithInterpolationMode:MGLInterpolationModeCategorical sourceStops:stopsDictionary attributeName:@"congestion" options:@{MGLStyleFunctionOptionDefaultValue : [MGLStyleValue valueWithRawValue:[UIColor greenColor]]}];


The dispatch_once block ensures that this line only executes once. But _trafficColor is an ivar, so if the developer creates multiple instances of MBXTrafficPlugin for some reason, those subsequent instances will be nonfunctional. Since all the instances of MBXTrafficPlugin should have the same color value, _trafficColor should be a global variable.

1ec5 · 2017-09-15T00:04:09Z

TrafficPlugin/MBXTrafficPlugin.m

+}
+
+// MARK: Add three traffic layers
+// Adds motorway, motorway-link, and trunk layer.


Nit: motorway_link.

1ec5 · 2017-09-15T00:09:13Z

TrafficPlugin/MBXTrafficPlugin.m

+
+// MARK: Add three traffic layers
+// Adds motorway, motorway-link, and trunk layer.
+- (void)addMotorwayLayerTo:(MGLMapView *)mapView below:(BOOL)below style:(MGLStyleLayer *)layer {


While it’s good form in Swift to end an argument label with a preposition, the standard style in Objective-C to end each selector piece with a noun describing the parameter: -addMotorwayLayerToMapView:below:styleLayer: (or, ideally, -addMotorwayLayerToMapView:positioned:relativeToStyleLayer:, with positioned being an above/below enumeration).

1ec5 · 2017-09-15T00:11:43Z

TrafficPlugin/MBXTrafficPlugin.m

+// MARK: Traffic Layer Removal
+- (void)removeFromMapView:(MGLMapView *)mapView {
+
+    for (MGLStyleLayer *layer in mapView.style.layers) if ([layer isKindOfClass:[MGLLineStyleLayer class]] && [((MGLLineStyleLayer *)layer).sourceIdentifier isEqualToString:@"traffic-source"]) {


Put the if on a separate line and use curly braces.

1ec5 · 2017-09-15T00:15:17Z

TrafficPlugin/MBXTrafficPlugin.m

+// MARK: Traffic Layer Removal
+- (void)removeFromMapView:(MGLMapView *)mapView {
+
+    for (MGLStyleLayer *layer in mapView.style.layers) if ([layer isKindOfClass:[MGLLineStyleLayer class]] && [((MGLLineStyleLayer *)layer).sourceIdentifier isEqualToString:@"traffic-source"]) {


FYI, it’s a bit fast-and-loose, but a trick I employ to make Objective-C casts more readable relies on weak typing:

for (MGLLineStyleLayer *layer in mapView.style.layers) { if ([layer isKindOfClass:[MGLLineStyleLayer class]] && [layer.sourceIdentifier isEqualToString:…]) { … } }

To be clear, there’s nothing wrong with the way you used a C cast on layer. Just thought I’d throw this tip out there.

1ec5 · 2017-09-15T00:17:10Z

TrafficPlugin/MBXTrafficPlugin.m

+    // Add traffic source to map style.
+    static dispatch_once_t onceToken;
+    dispatch_once(&onceToken, ^{
+        _source = [[MGLVectorSource alloc] initWithIdentifier:@"traffic-source" configurationURL:[NSURL URLWithString:@"mapbox://mapbox.mapbox-traffic-v1"]];


It’s conceivable that the developer may’ve already added a traffic source to the map with the identifier traffic-source. Adding another source with that same identifier could lead to undefined behavior. Consider prefixing the layer identifiers with this plugin framework’s bundle identifier, which you can either hard-code or determine programmatically.

1ec5 · 2017-09-15T19:53:17Z

TrafficPlugin/MBXTrafficPlugin.h

+
+extern MGLStyleValue *trafficColor;
+
+@interface MBXTrafficPlugin : NSObject <MBXPlugin>


This class needs a documentation comment.

1ec5 · 2017-09-15T19:53:26Z

TrafficPlugin/MBXTrafficPlugin.h

+#import <Foundation/Foundation.h>
+#import <Mapbox/Mapbox.h>
+
+extern MGLStyleValue *trafficColor;


No need to expose this value publicly in the header. Instead, move this declaration to the source file. In the source file, you won’t need extern, but consider using static.

1ec5 · 2017-09-15T19:53:46Z

MapboxPlugins.podspec

+
+  s.subspec 'PluginKit' do |core|
+    core.source_files  = 'PluginKit/*.h'
+    core.dependency 'Mapbox-iOS-SDK'


We should specify a minimum version of any dependency. v3.6 is a reasonable minimum, given that the traffic plugin uses the camera and style function syntaxes introduced in that version.

1ec5 · 2017-09-15T19:58:10Z

TrafficPlugin/MBXTrafficPlugin.m

+- (void) setupPropertiesFor:(MGLMapView *)mapView {
+    // Add traffic source to map style.
+    if (_source == nil) {
+        _sourceIdentifier = [NSString stringWithFormat:@"%@-traffic-source", [[NSBundle mainBundle] bundleIdentifier]];


+[NSBundle mainBundle] returns the main bundle, so when this code runs as part of an application, the bundle identifier will be that application’s bundle identifier, like com.example.MyApp. In the iOS SDK, we use a canary class to get the right bundle – in this case, that class can be MBXTrafficPlugin. (No need to include the rest of that iOS SDK method, which is specific to static libraries.)

1ec5 · 2017-09-15T19:58:54Z

TrafficPlugin/MBXTrafficPlugin.m

+// Adds motorway, motorway_link, and trunk layer.
+- (void)addMotorwayLayerTo:(MGLMapView *)mapView below:(BOOL)below style:(MGLStyleLayer *)layer {
+
+    MGLLineStyleLayer *motorwayLayer = [[MGLLineStyleLayer alloc] initWithIdentifier:@"mbx-traffic-motorway-layer" source:_source];


For consistency, consider prefixing with the framework’s bundle identifier, as with the source identifier above.

1ec5 · 2017-09-15T20:03:25Z

MapboxPlugins.podspec

+  # This description is used to generate tags and improve search results.
+  s.description  = "Add plugins to your Mapbox basemaps. Each plugin is packaged as a subspec. At the moment, the following plugin is available:
+                    * “Traffic” adds traffic congestion layers to a map view."
+  s.homepage     = "https://github.com/mapbox/mapbox-plugins-ios/"


We can specify trafficplugin.gif as s.screenshots, unless there’s a better screenshot to use here. s.screenshots requires a URL to an image that exists on a server. So we can use the raw URL to the image on GitHub, but make sure to use a permalink, ideally with the tag in the URL (example).

:thumbs-up:

jmkiley · 2017-09-16T01:15:39Z

Addressed the feedback @1ec5! Thank you so much.

1ec5

Getting close! In addition to the unresolved feedback in #9 (review), here are a few more comments.

1ec5 · 2017-09-16T08:19:12Z

MapboxPlugins.podspec

  s.homepage     = "https://github.com/mapbox/mapbox-plugins-ios/"
-
+  s.screenshot = 'https://github.com/mapbox/mapbox-plugins-ios/blob/master/TrafficPlugin/trafficplugin.gif'


This will need to be a URL to a raw image, not its HTML description page. I think it’ll be:

https://raw.githubusercontent.com/mapbox/mapbox-plugins-ios/master/TrafficPlugin/trafficplugin.gif

Oops, missed the previous feedback. Thanks!

1ec5 · 2017-09-16T08:23:43Z

TrafficPlugin/MBXTrafficPlugin.m

+- (void)addToMapView:(MGLMapView *)mapView above:(MGLStyleLayer *)layer {
+    [self setupPropertiesFor:mapView];
+
+    // Consolidate to one layer once lineWidth supports DDS.


Turn this into a TODO so we can more easily find it once we start requiring iOS SDK v3.7.0-alpha.1 and above. Might be worth opening a ticket too.

1ec5 · 2017-09-16T08:27:47Z

TrafficPlugin/MBXTrafficPlugin.m

+    [self setupPropertiesFor:mapView];
+
+    // Consolidate to one layer once lineWidth supports DDS.
+    [self addMotorwayLayerTo:mapView positioned:NO relativeTo:layer];


positioned:YES and positioned:NO sound a bit awkward. I previously suggested making an enumeration consisting of the cases Above and Below, but on second thought, we can remove the complexity around these methods by extracting out the actual insertion. Rename -addMotorwayLayerTo:positioned:relativeTo: to just -motorwayLayer and remove the calls to -insertLayer:{above,below}Layer:. Instead, have the method return the MGLStyleLayer and call the method like this:

[mapView.style insertLayer:self.primaryLayer above:layer];

That makes sense. Implemented it and it does look cleaner, thanks!

1ec5 · 2017-09-16T08:28:13Z

TrafficPlugin/MBXTrafficPlugin.m

+
+@property (nonatomic, retain) MGLVectorSource *source;
+@property (nonatomic, retain) MGLStyleValue *trafficColor;
+@property (nonatomic, retain) NSString *bundleIdentifier;


retain is a bit archaic; strong is more consistent with ARC. strong is the default, anyhow, so there doesn’t need to be a second qualifier for any of these properties.

jmkiley · 2017-09-18T17:08:18Z

I think I addressed the latest suggestions, @1ec5. Thank you so much for your suggestions 🙇‍♀️

1ec5 · 2017-09-19T16:16:16Z

MapboxPlugins.podspec

+                    * “Traffic” adds traffic congestion layers to a map view.
+                    Mapbox Plugins require version 3.6 of the Mapbox iOS SDK or higher."
+  s.homepage     = "https://github.com/mapbox/mapbox-plugins-ios/"
+  s.screenshot = 'https://raw.githubusercontent.com/mapbox/mapbox-plugins-ios/master/TrafficPlugin/trafficplugin.gif'


To keep this URL from going 404 if we ever change the path, let’s replace master with a tag name. Supposing we tag v0.0.1 as v0.0.1, the URL would be https://raw.githubusercontent.com/mapbox/mapbox-plugins-ios/v0.0.1/TrafficPlugin/trafficplugin.gif. We can automate that by interpolating a variable:

s.screenshot = "https://raw.githubusercontent.com/mapbox/mapbox-plugins-ios/v#{s.version}/TrafficPlugin/trafficplugin.gif"

1ec5 · 2017-09-19T16:16:33Z

TrafficPlugin/MBXTrafficPlugin.h

+
+
+/**
+ MBXTrafficPlugin adds a traffic congestion layer to Mapbox basemaps. For more information about Mapbox Traffic vector tile source, see https://www.mapbox.com/vector-tiles/mapbox-traffic-v1/


In Objective-C, use HTML or Markdown syntax for links in documentation comments:

For more information about the data powering this layer, see [the Mapbox Traffic source documentation](https://www.mapbox.com/vector-tiles/mapbox-traffic-v1/).

1ec5 · 2017-09-19T16:16:44Z

TrafficPlugin/MBXTrafficPlugin.h

+@interface MBXTrafficPlugin : NSObject <MBXPlugin>
+
+/**
+ Add traffic to a MGLMapView. This method inserts the traffic layer above the road layer. See the Mapbox Vector Tile Source layer reference (https://www.mapbox.com/vector-tiles/mapbox-streets-v7/#layer-reference) for more information about vector tile layers.


The linked documentation pertains to the Mapbox Streets source specifically, not the Mapbox Vector Tile format generally:

This method inserts the traffic layer immediately above the road layers if the style is based on the Mapbox Streets source. For more fine-grained control over the position of the traffic layers, use the -addToMapView:belowLayer: or -addToMapView:aboveLayer: method.

1ec5 · 2017-09-19T16:16:59Z

TrafficPlugin/MBXTrafficPlugin.h

+ @param mapView The map view that traffic will be displayed on.
+ @param layer The style layer that traffic will be inserted below. Use the `layers` property on a style to verify layer identifiers.
+ */
+- (void)addToMapView:(MGLMapView *)mapView below:(MGLStyleLayer *)layer;


My bad, I should’ve written -addToMapView:belowLayer:.

1ec5 · 2017-09-19T16:17:10Z

TrafficPlugin/MBXTrafficPlugin.h

+ @param mapView The map view that traffic will be displayed on.
+ @param layer The style layer that traffic will be inserted below. Use the `layers` property on a style to verify layer identifiers.
+ */
+- (void)addToMapView:(MGLMapView *)mapView above:(MGLStyleLayer *)layer;


Likewise, -addToMapView:aboveLayer:.

1ec5 · 2017-09-19T16:19:08Z

TrafficPlugin/MBXTrafficPlugin.m

+
+@implementation MBXTrafficPlugin
+
+static MGLStyleValue *_trafficColor;


A static global variable isn’t part of a class, so move this declaration to the top of the file, right under the import statement. Also, remove the _ and prefix it with the class name, since it’s no longer an internal variable but is still meant for use with that class: MBXTrafficPluginColorStyleValue.

1ec5 · 2017-09-19T16:20:05Z

TrafficPlugin/MBXTrafficPlugin.m

+@interface MBXTrafficPlugin ()
+
+@property (nonatomic) MGLVectorSource *source;
+@property (nonatomic) MGLStyleValue *trafficColor;


This property is no longer used.

1ec5 · 2017-09-19T16:21:36Z

TrafficPlugin/MBXTrafficPlugin.m

+    return motorwayLayer;
+}
+
+// Styless primary, secondary, and tertiary road layer.


Typo: “Styles the”. Wouldn’t hurt to make this a documentation comment, even if it’s a private method, since Quick Help can still read these comments when you’re working on this file.

jmkiley added 7 commits August 30, 2017 18:23

Added traffic layers

c668d1e

Moved files, fixed import

7fd48a7

Added method to select layer

2918d13

More refactoring of layer methods

a152b6e

Added ReadMe

40d9c89

Edited ReadMe

a0c9bb5

More ReadMe tweaks

7705747

jmkiley added the plugin: traffic label Aug 31, 2017

jmkiley added 2 commits August 31, 2017 10:09

Added method documentation

f91405c

Added a comment.

4b40bfd

jmkiley added 2 commits August 31, 2017 11:07

Refactored, added method to add traffic above a layer

5df3231

Refactored, added method to add traffic above a layer

9b67e32

Edited ReadMe, project schemes

7b69be8

jmkiley self-assigned this Aug 31, 2017

Edited ReadMe

860a970

friedbunny reviewed Aug 31, 2017

View reviewed changes

Edited ReadMe, .gitignore

cf8fb8f

boundsj reviewed Aug 31, 2017

View reviewed changes

jmkiley force-pushed the traffic-plugin branch from 99c1fa3 to 5302a40 Compare September 5, 2017 18:19

Reorganized project, updated ReadMe, LocalizationPlugin -> TrafficPlugin

4f3aa6a

jmkiley force-pushed the traffic-plugin branch from 5302a40 to 4f3aa6a Compare September 5, 2017 19:23

jmkiley added 4 commits September 5, 2017 12:46

Added framework to podspec

543c321

Fixed typo, changed framework path

d042115

Changed Mapbox import

94a48c0

updated import. again.

40e110f

jmkiley added 5 commits September 11, 2017 11:28

Started to address @1ec5's feedback.

ee348aa

Addressed @1ec5's feedback, edited gitignore

bbad61a

More edits, replaced gif

8ab9926

new -> array

2d3c1cc

Edited method to remove traffic

e92db09

jmkiley added 2 commits September 12, 2017 10:41

Edited podspec

720bebf

Maps Plugins -> Mapbox Plugins

b7851ad

Edited ReadMe for Traffic Plugin

569c9e7

friedbunny previously requested changes Sep 14, 2017

View reviewed changes

jmkiley added 2 commits September 14, 2017 13:05

Started to address @friedbunny's feedback

5617295

removed build, framework, mapbox_access_token

b75e474

1ec5 reviewed Sep 15, 2017

View reviewed changes

Addressed @1ec5's suggestions

c55b5db

1ec5 reviewed Sep 15, 2017

View reviewed changes

jmkiley added 2 commits September 15, 2017 17:08

Renamed some methods

c3619bf

Updated podspec

1fd4ed6

updated screenshot URL

411fb28

1ec5 reviewed Sep 16, 2017

View reviewed changes

Addressed @1ec5's feedback

79d2755

1ec5 reviewed Sep 19, 2017

View reviewed changes

jmkiley added 2 commits September 19, 2017 11:12

revisions, fixed typo

c51c5d0

Bumped podspec

e5f966d

jmkiley merged commit 0c60b57 into 1ec5-project Sep 19, 2017

jmkiley deleted the traffic-plugin branch September 19, 2017 18:19

		@@ -0,0 +1,5 @@
		extern const unsigned char TrafficPluginVersionString[];


		Test out Mapbox Plugins in the TestApp.

		1. Run `carthage bootstrap` to install the Mapbox iOS SDK.


		extern MGLStyleValue *trafficColor;

		@interface MBXTrafficPlugin : NSObject <MBXPlugin>

		s.homepage = "https://github.com/mapbox/mapbox-plugins-ios/"

		s.screenshot = 'https://github.com/mapbox/mapbox-plugins-ios/blob/master/TrafficPlugin/trafficplugin.gif'



		/**
		MBXTrafficPlugin adds a traffic congestion layer to Mapbox basemaps. For more information about Mapbox Traffic vector tile source, see https://www.mapbox.com/vector-tiles/mapbox-traffic-v1/


		@implementation MBXTrafficPlugin

		static MGLStyleValue *_trafficColor;

[WIP] Traffic plugin #9

[WIP] Traffic plugin #9

Conversation

jmkiley commented Aug 31, 2017 • edited Loading

friedbunny commented Aug 31, 2017

jmkiley commented Aug 31, 2017

Choose a reason for hiding this comment

jmkiley commented Aug 31, 2017

jmkiley commented Aug 31, 2017

Choose a reason for hiding this comment

jmkiley commented Aug 31, 2017

jmkiley commented Sep 11, 2017

jmkiley commented Sep 13, 2017

friedbunny commented Sep 14, 2017

friedbunny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

friedbunny Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

friedbunny Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Sep 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmkiley commented Sep 16, 2017

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Sep 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmkiley commented Sep 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmkiley commented Aug 31, 2017 •

edited

Loading

friedbunny Sep 14, 2017 •

edited

Loading

friedbunny Sep 14, 2017 •

edited

Loading

1ec5 Sep 14, 2017 •

edited

Loading

1ec5 Sep 16, 2017 •

edited

Loading