Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cashflow tables and related testing upgrades #3

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

malcolm-dsider
Copy link
Owner

No description provided.

@softwareengineerprogrammer

https://github.com/malcolm-dsider/geophires-x-nrel/actions/runs/8132096778/job/22222153748?pr=3 is failing due to python 3.8 syntax error:

E     File "/home/runner/work/geophires-x-nrel/geophires-x-nrel/.tox/py38/lib/python3.8/site-packages/geophires_x/Outputs.py", line 107
E       with (open(self.output_file, 'w', encoding='UTF-8') as f):

I believe this can be resolved by changing line 107 of Outputs.py to:

with open(self.output_file, 'w', encoding='UTF-8') as f:

(that is, remove wrapping parentheses)

@malcolm-dsider
Copy link
Owner Author

malcolm-dsider commented Mar 3, 2024 via email

@malcolm-dsider
Copy link
Owner Author

malcolm-dsider commented Mar 3, 2024 via email

@softwareengineerprogrammer

@malcolm-dsider disregard my comment about the next failing action for now - defer to our offline discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants