Add coverage to tests #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hi @timcallow, thanks for the PR, looks great! I would merge it as is from the code side, but have a few clarifying questions about the process as a whole:
|
RandomDefaultUser
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #592
Since the coverage reports a number of 62%, I've set the
--cov-fail-underparameter to 60%, i.e. the CPU tests will fail if the coverage dips below that.We could use a third-party app like codecov if we want more functionality - for example then we could have a separate test for coverage. That's what I did for atoMEC. This could also be introduced in a future PR if considered useful. I'll leave it up to you @RandomDefaultUser