Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage to tests #592

Closed
timcallow opened this issue Oct 23, 2024 · 1 comment · Fixed by #594
Closed

Add coverage to tests #592

timcallow opened this issue Oct 23, 2024 · 1 comment · Fixed by #594

Comments

@timcallow
Copy link
Contributor

I suggest to add coverage to the tests. At the moment, if someone adds a new feature, the onus is on them to remember to add tests to check that it's working. Also it gives more confidence when making changes if you can see the test-suite is really covering the full range of functionality.

We could set it up so that if the coverage drops below a certain threshold, then the tests fail. This is how I set it up in atoMEC.

What do you think @RandomDefaultUser?

@RandomDefaultUser
Copy link
Member

I think that sounds like a great idea!

If you have the capacity, feel free to prepare a PR!

@timcallow timcallow linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants