onDragStart cannot move iframes/embeds
#550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d onDragEnd is never triggered
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not entirely sure of the underlying issues which cause video/iframe/embed blocks to cause ST
onDragStartto fail before completing the block drag event, however it affects all iframes, even the Video block that comes with ST by default. Thest-drag-elementclass is added to the element, but then all handles are removed and the element is rendered without content.By removing the following lines of code the user is still able to see where the block is being moved to and the drag event is able to finish successfully with all blocks, text, video, custom iframe.
This PR is related to #549