Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordering Iframes/embeds causes blocks to be blanked #549

Open
prdanelli opened this issue Sep 17, 2018 · 2 comments
Open

Reordering Iframes/embeds causes blocks to be blanked #549

prdanelli opened this issue Sep 17, 2018 · 2 comments

Comments

@prdanelli
Copy link

After some digging I found that the onDragStart method within block-reorder.js creates a cloned element, however if the block is an embed, then the process never completes, so st-block--dragging class is never removed from the block and it looks like its crashed.

The following method seems to work perfectly without generating the text preview:

onDragStart: function onDragStart(ev) {
  var block = this.block;
  ev.dataTransfer.setData("text/plain", this.blockId());
  this.mediator.trigger("block-controls:hide");
  EventBus.trigger("block:reorder:dragstart");
},
@raffij
Copy link
Contributor

raffij commented Sep 18, 2018

Is this something you'd like to submit as a pull request?

@prdanelli
Copy link
Author

No problem. I've added it here: #550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants