Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ubuntu dependencies not to break ROS installation #474

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix ubuntu dependencies not to break ROS installation #474

wants to merge 6 commits into from

Conversation

VanDavv
Copy link
Contributor

@VanDavv VanDavv commented Jan 3, 2022

No description provided.

themarpe
themarpe requested changes Jan 4, 2022
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be able to break ARM ROS installations
IMO, check for ROS OS and install / not install pyqt5 package based on that information

@VanDavv VanDavv marked this pull request as ready for review January 17, 2022 15:01
themarpe
themarpe approved these changes Jan 17, 2022
View reviewed changes
Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if works as intended.
(Note, the check isn't important IMO - if its already installed, it wont reinstall)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themarpe themarpe themarpe approved these changes

@saching13 saching13 Awaiting requested review from saching13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VanDavv @themarpe