-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test cases test_colors
and test_ellipse_axes
seem to be impure
#97
Comments
Thanks for the report. I am familiar with Nix as I use NixOS on my laptop (which, unfortunately, is in the shop). Running the test 100 times on my work machine (Ubuntu) results in 100 successes and those tests in particular should be deterministic. There is obviously something I am missing. |
Thanks for the reaction! It's fixed for now in |
…texture.test_haralick3d` testcase As stated in NixOS#46368, this package seems to have issues with impure tests (reported in luispedro/mahotas#97). Unfortunately the `release-18.09` job on Hydra fails at the attempt to build this package since `test_moments.test_normalize1` and `test_texture.test_haralick3d` breaks. Until the root cause is identified, we skip the disabled tests to ensure that the resulting package is not entirely broken (which can't be confirmed with `doCheck = false`). See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175 /cc @xeji @luispedro
…texture.test_haralick3d` testcase (#46793) As stated in #46368, this package seems to have issues with impure tests (reported in luispedro/mahotas#97). Unfortunately the `release-18.09` job on Hydra fails at the attempt to build this package since `test_moments.test_normalize1` and `test_texture.test_haralick3d` breaks. Until the root cause is identified, we skip the disabled tests to ensure that the resulting package is not entirely broken (which can't be confirmed with `doCheck = false`). See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175 /cc @xeji @luispedro (cherry picked from commit 5f2eacc)
…texture.test_haralick3d` testcase (#46793) As stated in #46368, this package seems to have issues with impure tests (reported in luispedro/mahotas#97). Unfortunately the `release-18.09` job on Hydra fails at the attempt to build this package since `test_moments.test_normalize1` and `test_texture.test_haralick3d` breaks. Until the root cause is identified, we skip the disabled tests to ensure that the resulting package is not entirely broken (which can't be confirmed with `doCheck = false`). See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175 /cc @xeji @luispedro
The package
mahotas
is part of the Nix package set which aims to provide reproducible builds. Unfortunatelymahotas
is broken ATM since two testcases (namelytest_colors
andtest_ellipse_axes
) are not fully pure. When running the build, the tests sometimes fail without a predictable pattern.See NixOS/nixpkgs#46368 for further reference.
The text was updated successfully, but these errors were encountered: