Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mahotas: skip test_moments.test_normalize testcase #46793

Merged
merged 1 commit into from
Sep 17, 2018
Merged

pythonPackages.mahotas: skip test_moments.test_normalize testcase #46793

merged 1 commit into from
Sep 17, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 17, 2018 •
edited
Loading

Motivation for this change

As stated in #46368, this package seems to have issues with impure tests
(reported in luispedro/mahotas#97).

Unfortunately the release-18.09 job on Hydra fails at the attempt to
build this package since test_moments.test_normalize1 breaks. Until
the root cause is identified, we skip the disabled tests to ensure that
the resulting package is not entirely broken (which can't be confirmed
with doCheck = false).

See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux
See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner September 17, 2018 17:46
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 17, 2018
@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

@GrahamcOfBorg build python27Packages.mahotas python36Packages.mahotas

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.mahotas, python36Packages.mahotas

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python27Packages.mahotas, python36Packages.mahotas

Partial log (click to expand)

imread.tests.test_png.test_asym ... ok
imread.tests.test_png.test_random ... ok
imread.tests.test_png.test_non_carray ... ok
imread.tests.test_png.test_binary ... ok
imread.tests.test_png.test_error ... terminate called after throwing an instance of 'CannotReadError'
  what():  Not a PNG file
/nix/store/pjq5v1xgljr4ygb1h1xfybdjydczcqiw-stdenv-linux/setup: line 1291:  1749 Aborted                 /nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3.6m nix_run_setup test
builder for '/nix/store/w81gv1slijijp030n691difsrkabq9yh-python3.6-python-imread-0.6.drv' failed with exit code 134
cannot build derivation '/nix/store/clz9lhfj7n3qwhf3csn42ip2z66aaii8-python3.6-mahotas-1.4.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/clz9lhfj7n3qwhf3csn42ip2z66aaii8-python3.6-mahotas-1.4.2.drv', '/nix/store/zj1l5d2gmsrxy63m66gfl66z97l3cs4z-python2.7-mahotas-1.4.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python27Packages.mahotas, python36Packages.mahotas

Partial log (click to expand)

[watershed]: Compare floating point input with integer input ... ok
mahotas.tests.test_zernike.test_zernike ... ok
mahotas.tests.test_zernike.test_zernike_cm ... ok
mahotas.tests.test_zernike.test_not_nan ... ok

----------------------------------------------------------------------
Ran 322 tests in 16.399s

OK (skipped=1)
error: build of '/nix/store/2ksvqdhrx3qhrss9a5h69p0z7g8v6j92-python2.7-mahotas-1.4.2.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

I can reproduce the python2 test failure locally, so let's disable that as well.

@Ma27
pythonPackages.mahotas: skip test_moments.test_normalize and `test_…
b6f61e4 
…texture.test_haralick3d` testcase

As stated in NixOS#46368, this package seems to have issues with impure tests
(reported in luispedro/mahotas#97).

Unfortunately the `release-18.09` job on Hydra fails at the attempt to
build this package since `test_moments.test_normalize1` and
`test_texture.test_haralick3d` breaks. Until
the root cause is identified, we skip the disabled tests to ensure that
the resulting package is not entirely broken (which can't be confirmed
with `doCheck = false`).

See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux
See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux
See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175

/cc @xeji @luispedro
@Ma27 Ma27 force-pushed the fix-mahotas-tests branch from 713d080 to b6f61e4 Compare September 17, 2018 19:15
@Ma27
Copy link
Member Author

Ma27 commented Sep 17, 2018

@xeji done :)

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

Thanks!
@GrahamcOfBorg build python27Packages.mahotas python36Packages.mahotas

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python27Packages.mahotas, python36Packages.mahotas

Partial log (click to expand)

imread.tests.test_png.test_asym ... ok
imread.tests.test_png.test_random ... ok
imread.tests.test_png.test_non_carray ... ok
imread.tests.test_png.test_binary ... ok
imread.tests.test_png.test_error ... terminate called after throwing an instance of 'CannotReadError'
  what():  Not a PNG file
/nix/store/pjq5v1xgljr4ygb1h1xfybdjydczcqiw-stdenv-linux/setup: line 1291:  1749 Aborted                 /nix/store/sb88r9crdhinhkm6vpxwzf5zmij86p8v-python3-3.6.6/bin/python3.6m nix_run_setup test
builder for '/nix/store/w81gv1slijijp030n691difsrkabq9yh-python3.6-python-imread-0.6.drv' failed with exit code 134
cannot build derivation '/nix/store/k1x8l7jd9d0ygw6fx9c60ns7cq1nb7nj-python3.6-mahotas-1.4.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/hhm32gns7ghaj45fz2nbhjdpjx69k10m-python2.7-mahotas-1.4.2.drv', '/nix/store/k1x8l7jd9d0ygw6fx9c60ns7cq1nb7nj-python3.6-mahotas-1.4.2.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.mahotas, python36Packages.mahotas

Partial log (click to expand)

mahotas.tests.test_zernike.test_zernike ... ok
mahotas.tests.test_zernike.test_zernike_cm ... ok
mahotas.tests.test_zernike.test_not_nan ... ok

----------------------------------------------------------------------
Ran 321 tests in 15.052s

OK (skipped=1)
/nix/store/i582axb0q15asq1qbpa79rwrdfzvzyb7-python2.7-mahotas-1.4.2
/nix/store/ywib1j4x9wwjz2jwrfck3vgn8hc9vmsj-python3.6-mahotas-1.4.2

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

aarch64 failure is in a dependency, let's ignore it for now.

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

Let's hope this work on Hydra as well 😄

@xeji xeji merged commit 5f2eacc into NixOS:master Sep 17, 2018
xeji pushed a commit that referenced this pull request Sep 17, 2018
@Ma27 @xeji
pythonPackages.mahotas: skip test_moments.test_normalize and `test_…
ff791c8 
…texture.test_haralick3d` testcase (#46793)

As stated in #46368, this package seems to have issues with impure tests
(reported in luispedro/mahotas#97).

Unfortunately the `release-18.09` job on Hydra fails at the attempt to
build this package since `test_moments.test_normalize1` and
`test_texture.test_haralick3d` breaks. Until
the root cause is identified, we skip the disabled tests to ensure that
the resulting package is not entirely broken (which can't be confirmed
with `doCheck = false`).

See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux
See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux
See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175

/cc @xeji @luispedro

(cherry picked from commit 5f2eacc)
@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

backported: ff791c8

@Ma27 Ma27 deleted the fix-mahotas-tests branch September 17, 2018 19:37
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.mahotas, python36Packages.mahotas

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ma27 @xeji @GrahamcOfBorg