Skip to content

Commit

Permalink
pythonPackages.mahotas: skip test_moments.test_normalize and `test_…
Browse files Browse the repository at this point in the history
…texture.test_haralick3d` testcase (#46793)

As stated in #46368, this package seems to have issues with impure tests
(reported in luispedro/mahotas#97).

Unfortunately the `release-18.09` job on Hydra fails at the attempt to
build this package since `test_moments.test_normalize1` and
`test_texture.test_haralick3d` breaks. Until
the root cause is identified, we skip the disabled tests to ensure that
the resulting package is not entirely broken (which can't be confirmed
with `doCheck = false`).

See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python27Packages.mahotas.x86_64-linux
See https://hydra.nixos.org/job/nixos/release-18.09/nixpkgs.python36Packages.mahotas.x86_64-linux
See https://logs.nix.ci/?key=nixos/nixpkgs.46793&attempt_id=b85a638d-dcb0-41d3-ab2a-9616a3bb0175

/cc @xeji @luispedro

(cherry picked from commit 5f2eacc)
  • Loading branch information
Ma27 authored and xeji committed Sep 17, 2018
1 parent 3477239 commit ff791c8
Showing 1 changed file with 42 additions and 0 deletions.
42 changes: 42 additions & 0 deletions pkgs/development/python-modules/mahotas/disable-impure-tests.patch
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,45 @@ index 462f467..2381793 100644
def test_ellipse_axes():
Y,X = np.mgrid[:1024,:1024]
Y = Y/1024.
diff --git a/mahotas/tests/test_moments.py b/mahotas/tests/test_moments.py
index 686c7c3..ba3487b 100644
--- a/mahotas/tests/test_moments.py
+++ b/mahotas/tests/test_moments.py
@@ -1,6 +1,7 @@
import numpy as np
import mahotas as mh
from mahotas.features.moments import moments
+from nose.tools import nottest

def _slow(A, p0, p1, cm):
c0,c1 = cm
@@ -28,7 +29,7 @@ def test_against_slow():
yield perform, 1, 2, (0, 0), A
yield perform, 1, 0, (0, 0), A

-
+@nottest
def test_normalize():
A,B = np.meshgrid(np.arange(128),np.arange(128))
for p0,p1 in [(1,1), (1,2), (2,1), (2,2)]:
diff --git a/mahotas/tests/test_texture.py b/mahotas/tests/test_texture.py
index 7e101ba..af1305d 100644
--- a/mahotas/tests/test_texture.py
+++ b/mahotas/tests/test_texture.py
@@ -2,7 +2,7 @@ import numpy as np
from mahotas.features import texture
import mahotas as mh
import mahotas.features._texture
-from nose.tools import raises
+from nose.tools import raises, nottest

def test__cooccurence():
cooccurence = mahotas.features._texture.cooccurence
@@ -149,6 +149,7 @@ def test_float_haralick():
A[2,2]=12
texture.haralick(A)

+@nottest
def test_haralick3d():
np.random.seed(22)
img = mahotas.stretch(255*np.random.rand(20,20,4))

0 comments on commit ff791c8

Please sign in to comment.