-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup tools #1756
Merged
Merged
Cleanup tools #1756
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
da8a836
Use prettier own instead of eslint plugin
nix6839 91672ea
Extend prettier config angular eslint
nix6839 bc15bfd
Upgrade root prettier to 3
nix6839 78db664
Fix css syntax errors
nix6839 fe10a7f
Change eslint ignore to prettier ignore
nix6839 ef1c3ef
Ignore formatting for outputs
nix6839 502deeb
Fix lint-staged error when edited multiple files
nix6839 4d2b1e3
Bump pnpm version
nix6839 3bd52fa
Remove unnecessary pnpm config
nix6839 aafac47
Merge branch 'main' into cleanup-tools
ericfennis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
pnpm-lock.yaml | ||
|
||
# lucide-angular | ||
packages/lucide-angular/.angular/cache | ||
|
||
# lucide-static | ||
packages/lucide-static/icons | ||
packages/lucide-static/lib | ||
packages/lucide-static/sprite.svg | ||
packages/lucide-static/tags.json | ||
packages/lucide-static/icon-nodes.json | ||
packages/lucide-static/font | ||
|
||
# lucide-svelte | ||
packages/lucide-svelte/src/icons/*.svelte | ||
packages/lucide-svelte/.svelte-kit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/** | ||
* @param {string[]} filenames | ||
* @returns {string} | ||
*/ | ||
const filenamesToAjvOption = (filenames) => filenames.map((filename) => `-d ${filename}`).join(' '); | ||
|
||
/** @satisfies {import('lint-staged').Config} */ | ||
const config = { | ||
'icons/*.svg': [ | ||
'node ./scripts/optimizeStagedSvgs.mjs', | ||
'node ./scripts/generateNextJSAliases.mjs', | ||
], | ||
'icons/*.json': (filenames) => [ | ||
`ajv --spec=draft2020 -s icon.schema.json ${filenamesToAjvOption(filenames)}`, | ||
`prettier --write ${filenames.join(' ')}`, | ||
], | ||
'categories/*.json': (filenames) => [ | ||
`ajv --spec=draft2020 -s category.schema.json ${filenamesToAjvOption(filenames)}`, | ||
`prettier --write ${filenames.join(' ')}`, | ||
], | ||
}; | ||
|
||
export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,10 +30,11 @@ | |
"generate:nextJSAliases": "node ./scripts/generateNextJSAliases.mjs", | ||
"postinstall": "husky install", | ||
"lint:es": "eslint .", | ||
"lint:format": "prettier \"**/*.{js,mjs,ts,jsx,tsx,html,css,scss,json,yml,yaml}\" --write", | ||
"lint:json:icons": "ajv --spec=draft2020 -s icon.schema.json -d 'icons/*.json' > /dev/null", | ||
"lint:json:categories": "ajv --spec=draft2020 -s category.schema.json -d 'categories/*.json' > /dev/null", | ||
"lint:json": "pnpm run lint:json:icons && pnpm run lint:json:categories", | ||
"lint": "pnpm lint:es && pnpm lint:json", | ||
"lint": "pnpm lint:es && pnpm lint:format && pnpm lint:json", | ||
"prepare": "husky install", | ||
"gi": "node ./scripts/generate/generateIcons.mjs" | ||
}, | ||
|
@@ -52,40 +53,19 @@ | |
"eslint-import-resolver-custom-alias": "^1.3.2", | ||
"eslint-import-resolver-typescript": "^3.6.1", | ||
"eslint-plugin-import": "^2.29.1", | ||
"eslint-plugin-prettier": "^4.2.1", | ||
"husky": "^8.0.3", | ||
"lint-staged": "^13.3.0", | ||
"minimist": "^1.2.8", | ||
"node-fetch": "^3.3.2", | ||
"p-memoize": "^7.1.1", | ||
"prettier": "2.7.1", | ||
"prettier": "3.1.1", | ||
"semver": "^7.5.4", | ||
"simple-git": "^3.21.0", | ||
"svgo": "^3.1.0", | ||
"svgson": "^5.3.1" | ||
}, | ||
"lint-staged": { | ||
"icons/*.svg": [ | ||
"node ./scripts/optimizeStagedSvgs.mjs", | ||
"node ./scripts/generateNextJSAliases.mjs" | ||
], | ||
"icons/*.json": [ | ||
"ajv --spec=draft2020 -s icon.schema.json -d", | ||
"prettier --write --print-width=0" | ||
], | ||
"categories/*.json": [ | ||
"ajv --spec=draft2020 -s category.schema.json -d", | ||
"prettier --write --print-width=0" | ||
] | ||
}, | ||
"packageManager": "[email protected]", | ||
"packageManager": "[email protected]+sha256.9cebf61abd83f68177b29484da72da9751390eaad46dfc3072d266bfbb1ba7bf", | ||
"pnpm": { | ||
"peerDependencyRules": { | ||
"ignoreMissing": [ | ||
"@babel/core", | ||
"@babel/preset-env" | ||
] | ||
}, | ||
"packageExtensions": { | ||
"vue-template-compiler": { | ||
"peerDependencies": { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
/** @satisfies {import('prettier').Config} */ | ||
const config = { | ||
singleQuote: true, | ||
trailingComma: 'all', | ||
printWidth: 100, | ||
overrides: [ | ||
{ | ||
files: ['icons/*.json', 'categories/*.json'], | ||
options: { | ||
printWidth: 0, | ||
}, | ||
}, | ||
], | ||
}; | ||
|
||
export default config; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should run eslint and typecheck here as well IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this PR is merged, I will submit a separate PR related to ESLint. How about we handle it together at that time?