Cleanup tools #1756
Merged
Cleanup tools #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 dependencies
jguddas
reviewed
Dec 28, 2023
| */ | ||
| const filenamesToAjvOption = (filenames) => filenames.map((filename) => `-d ${filename}`).join(' '); | ||
|
|
||
| /** @satisfies {import('lint-staged').Config} */ |
There was a problem hiding this comment.
We should run eslint and typecheck here as well IMO.
There was a problem hiding this comment.
After this PR is merged, I will submit a separate PR related to ESLint. How about we handle it together at that time?
nix6839
force-pushed
the
cleanup-tools
branch
3 times, most recently
from
7285420 to
d508672
Compare
nix6839
force-pushed
the
cleanup-tools
branch
2 times, most recently
from
36666d8 to
db19681
Compare
jguddas
reviewed
Jan 3, 2024
nix6839
force-pushed
the
cleanup-tools
branch
3 times, most recently
from
8222406 to
7f0f2b3
Compare
nix6839
force-pushed
the
cleanup-tools
branch
from
7f0f2b3 to
3bd52fa
Compare
ericfennis
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Description
I haven't applied formatting yet to make it easier to view the diff. If you agree with this PR, I can also include formatting in the commit.
Before Submitting