-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed import of toKebabCase helper function #1603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't import things outside package scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @jguddas We should not import outside the package scope.
But the cleanup is nice, and we should do this in another way.
We could create a separate package in the packages directory called "utils". Which exports this function. This is also useful for other code we want to share between packages.
Would you like to create this package? In the package.json
file the name should be "@lucide/utils" and the private
property should be set on true
.
All dependent package get a new "dependency" field: "@lucide/utils": "workspace:*",
If you need help let me know.
@ericfennis Ok got it! I'll work on it! |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
What is the purpose of this pull request?
Description
There were comments in multiple files asking to import the 'toKebabCase' helper function instead of redefining the function everywhere. So, fixed the import statements in all such instances and removed the existing comments asking for this to be done. Overall, not a feature or a bug fix, just some code cleanup.
Before Submitting