refactor: Adds repo shared package @lucide/shared
#1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 dependencies
github-actions
bot
added
⚛️ react native package
Added or changed iconsPreview cohesion      Preview stroke widths    DPI Preview (24px)  Icon X-rays 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1603
What is the purpose of this pull request?
Description
This refactor adds the ability for a shared package across packages. This continues on the work from @SamstyleGhost.
It needed some extra work to "bundle" the code from the shared package into each package.
This resulted in refactoring the build process from the
lucide-solidpackage, which wasn't able to correctly include the shared package in the build. The idea was not to publish the shared package on NPM because that would need extra build processes and create a lot of extra work in maintaining versions.The shared package will be used for the upcoming features we want to add like creating icons from external iconNodes.