-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tickets/DM-45261: Add description field to ATCalsys and MTCalsys schema validation files #168
Open
MarcoRocchietti
wants to merge
4
commits into
develop
Choose a base branch
from
tickets/DM-45261
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d9c1b74
Add description fields to atcalsys_schema.yaml
MarcoRocchietti 9ea7244
Fix some typos and redaction of atcalsys_schema.yaml
MarcoRocchietti c94226c
Add description fields to mtcalsys_schema.yaml
MarcoRocchietti 6a1f90b
Add missing type to eletrometer_range attribute in mtcalsys_schema.yaml
MarcoRocchietti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,48 +4,105 @@ title: Configuration file validation schema of Auxiliary Telescope Calibration S | |
type: object | ||
properties: | ||
calib_type: | ||
description: >- | ||
Type of flat field calibration. There are two types, `Whitelight` for | ||
broad spectrum light and `Mono` for monochromatic. | ||
type: string | ||
enum: | ||
- Mono | ||
- WhiteLight | ||
use_camera: | ||
description: Indicates whether the operation requires a camera. | ||
type: boolean | ||
atspec_filter: | ||
description: Name of the filter to select for the spectrograph. | ||
type: string | ||
atspec_grating: | ||
description: Name of the grating to select for the spectrograph. | ||
type: string | ||
wavelength: | ||
description: >- | ||
Center wavelength value in nm, used for configuring the monochromator | ||
output. | ||
type: number | ||
wavelength_width: | ||
description: >- | ||
Optional. Defines the width of the wavelength scan range to configure the | ||
monochromator for the flat-field calibration sequence when using | ||
monochromatic light. | ||
type: number | ||
wavelength_resolution: | ||
description: >- | ||
Optional. When using a monochromatic light source, it defines the | ||
resolution used to sample values within the scan range, which has a width | ||
defined by `wavelength_width` and is centered around the `wavelength` | ||
attribute. | ||
type: number | ||
monochromator_grating: | ||
description: >- | ||
Select the grating of the monochromator that will be in the path of | ||
light. | ||
type: string | ||
enum: | ||
- MIRROR | ||
- RED | ||
- BLUE | ||
exit_slit: | ||
description: >- | ||
Exit slit width for the monochromator, from 0 to 7 mm (inclusive). | ||
type: number | ||
entrance_slit: | ||
description: >- | ||
Entrance slit width for the monochromator, from 0 to 7mm (inclusive). | ||
type: number | ||
electrometer_integration_time: | ||
description: >- | ||
Integration time in seconds (166.67e-6 to 200e-3) for each sample. | ||
|
||
The integration time (measurement speed) of the analog to digital (A/D) | ||
converter, the period of time the input signal is measured (also known as | ||
aperture). Due to the time it takes to read the buffer and process the | ||
data, this is not the rate at which samples are taken. This is generally | ||
specified by the Power Line Cycle (PLC), where 1 PLC for 60Hz is | ||
16.67msec. Fast integration=0.01PLC; Medium integration=0.1PLC; Normal | ||
(default) integration = 1PLC; High Accuracy integration=10PLC. Here the | ||
integration is set in seconds. | ||
type: number | ||
electrometer_mode: | ||
description: >- | ||
Set electrometer to use different modes. The units recorded will be Amps | ||
for `CURRENT`, Volts for `VOLTAGE`, Coulombs for `CHARGE`, and Ohms for | ||
`RESISTANCE`. | ||
type: string | ||
enum: | ||
- CURRENT | ||
- CHARGE | ||
- VOLTAGE | ||
- RESISTANCE | ||
electrometer_range: | ||
description: >- | ||
Set measurement range, which effects the accuracy of measurements and the | ||
max signal that can be measured. The maximum input signal is 105% of the | ||
measurement range. It will set the value for the current mode selected. | ||
Auto-range will automatically go to the most sensitive (optimized) range | ||
to make measurements. It is recommended to use autorange. When the | ||
measurement range is changed, a zero correction will be performed. | ||
|
||
-1 for automatic range. Volts range from 0 to 210 Volts, Current range | ||
from 0 to 21e-3 Amps, Resistance from 0 to 100e18 Ohms, Charge from 0 to | ||
+2.1e-6 Coulombs. | ||
type: number | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, it may have too much information. Let me know if it should be summarized. |
||
use_fiberspectrograph: | ||
description: >- | ||
Identifies if the fiberspectrograph will be used in the exposure. | ||
type: boolean | ||
use_electrometer: | ||
description: >- | ||
Identifies if the electrometer will be used in the exposure. | ||
type: boolean | ||
exposure_times: | ||
description: >- | ||
List of Camera exposure times, in secs | ||
type: array | ||
items: | ||
type: number | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I'm including a lot of information. I guess it could be more concise. Let me know if the extra paragraph should be summarized or removed. I have taken it from the command specification.