DM-48364: mobu - update docs

[fajpunk]

No description provided.

[rra]

I think we talked about this, but I don't remember the result: I think we decided that we were going to inject this value via Argo CD based on the environment configuration so that, eventually, no one needs to set this manually, right?

[fajpunk]

I think we talked about this, but I don't remember the result: I think we decided that we were going to inject this value via Argo CD based on the environment configuration so that, eventually, no one needs to set this manually, right?

Yep, ideally no one has to set this manually, but I didn't think we decided exactly how we were going to do it. Is it possible to do it from the ArgoCD environment now? Other than doing something like parsing the environments/ values yaml files somehow?

[jonathansick]

It's besides this review but I noticed that Mobu has two GitHub Apps now. Did you consider having one app and putting either a configuration file in the target repos or configuration in Phalanx saying what operations are enabled on that repo?

[fajpunk]

Did you consider having one app and putting either a configuration file in the target repos or configuration in Phalanx saying what operations are enabled on that repo?

A few reasons, not all of them particularly convincing :)

• We never want the CI functionality enabled in production environments. This could be configured in Phalanx though.
• Different repos may want to do their CI in different environments.
  • The CI environments could be configured in an in-repo config file, but then Mobu would have to clone the repo and check the config file for every check_run and check_suite event. That would probably be fine
  • The repos that an env handles CI for could be configured in Phalanx. This could be a slight pain for new repos, but maybe is more in the spirit of using Phalanx as the source of truth for platform configuration.

[frossie]

I think we talked about this, but I don't remember the result: I think we decided that we were going to inject this value via Argo CD based on the environment configuration so that, eventually, no one needs to set this manually, right?

I think this is a placeholder pending service discovery?

[fajpunk]

I think we talked about this, but I don't remember the result: I think we decided that we were going to inject this value via Argo CD based on the environment configuration so that, eventually, no one needs to set this manually, right?

I think this is a placeholder pending service discovery?

Yep, and the Argo CD injection was done in this PR.