review feedback

lsst-sqre · Jan 8, 2025 · dd05f8e · dd05f8e
1 parent d92bb91
commit dd05f8e
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 8 deletions.
diff --git a/applications/mobu/README.md b/applications/mobu/README.md
@@ -14,7 +14,7 @@ Continuous integration testing
 |-----|------|---------|-------------|
 | affinity | object | `{}` | Affinity rules for the mobu frontend pod |
 | config.autostart | list | `[]` | Autostart specification. Must be a list of mobu flock specifications. Each flock listed will be automatically started when mobu is started. |
-| config.available_services | list | `[]` | Which applications (tap, butler, etc.) are available in this environment. Notebooks can specify a `mobu.required_services` list in their metadata, and mobu will only run them if all services in that list are in this `available_services` list. See https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks |
+| config.availableServices | list | `[]` | Which applications (tap, butler, etc.) are available in this environment. Notebooks can specify a `mobu.required_services` list in their metadata, and mobu will only run them if all services in that list are in this `availableServices` list. See https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks |
 | config.githubCiApp | string | disabled. | Configuration for the GitHub CI app integration. See https://mobu.lsst.io/operations/github_ci_app.html#add-phalanx-configuration |
 | config.githubRefreshApp | string | disabled. | Configuration for the GitHub refresh app integration. See https://mobu.lsst.io/operations/github_refresh_app.html#add-phalanx-configuration |
 | config.logLevel | string | `"INFO"` | Log level. Set to 'DEBUG' to include the output from all flocks in the main mobu log. |

diff --git a/applications/mobu/tests/github_ci_app_enabled_test.yaml b/applications/mobu/tests/github_ci_app_enabled_test.yaml
@@ -52,7 +52,7 @@ tests:
           path: "data['config.yaml']"
           value: |
             autostart: []
-            available_services: []
+            availableServices: []
             githubCiApp:
               acceptedGithubOrgs:
               - org1

diff --git a/applications/mobu/tests/github_disabled_test.yaml b/applications/mobu/tests/github_disabled_test.yaml
@@ -14,7 +14,7 @@ tests:
           path: "data['config.yaml']"
           value: |
             autostart: []
-            available_services: []
+            availableServices: []
             githubCiApp: null
             githubRefreshApp: null
             logLevel: INFO

diff --git a/applications/mobu/tests/github_refresh_app_enabled_test.yaml b/applications/mobu/tests/github_refresh_app_enabled_test.yaml
@@ -36,7 +36,7 @@ tests:
           path: "data['config.yaml']"
           value: |
             autostart: []
-            available_services: []
+            availableServices: []
             githubCiApp: null
             githubRefreshApp:
               acceptedGithubOrgs:

diff --git a/applications/mobu/values.yaml b/applications/mobu/values.yaml
@@ -22,10 +22,12 @@ ingress:
   annotations: {}
 
 config:
-  # -- Which applications (tap, butler, etc.) are available in this environment.
-  # Notebooks can specify a `mobu.required_services` list in their metadata, and mobu will only run them if all services in that list are in this `available_services` list.
-  # See https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks
-  available_services: []
+  # -- Which applications (tap, butler, etc.) are available in this
+  # environment. Notebooks can specify a `mobu.required_services` list in their
+  # metadata, and mobu will only run them if all services in that list are in
+  # this `availableServices` list. See
+  # https://mobu.lsst.io/user_guide/in_repo_config.html#service-specific-notebooks
+  availableServices: []
 
   # -- Autostart specification. Must be a list of mobu flock specifications.
   # Each flock listed will be automatically started when mobu is started.