-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Improve preliminary AI feedback
#9324
Merged
krusche
merged 37 commits into
develop
from
feature/programming-exercises/revised-feedback
Oct 12, 2024
Merged
Programming exercises
: Improve preliminary AI feedback
#9324
krusche
merged 37 commits into
develop
from
feature/programming-exercises/revised-feedback
Oct 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he repository view
github-actions
bot
added
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
labels
Sep 17, 2024
|
github-actions
bot
added
the
deployment-error
Added by deployment workflows if an error occured
label
Sep 17, 2024
dmytropolityka
removed
the
deployment-error
Added by deployment workflows if an error occured
label
Sep 17, 2024
…vised-feedback' into feature/programming-exercises/revised-feedback
dmytropolityka
temporarily deployed
to
artemis-test1.artemis.cit.tum.de
September 17, 2024 15:26 — with
GitHub Actions
Inactive
dmytropolityka
changed the title
Feature/programming exercises/revised feedback
Sep 17, 2024
Programming exercises
: Refactoring of Preliminary Feedback
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
github-actions
bot
added
exercise
Pull requests that affect the corresponding module
programming
Pull requests that affect the corresponding module
labels
Sep 30, 2024
This was referenced Oct 16, 2024
This was referenced Oct 23, 2024
Merged
This was referenced Nov 3, 2024
This was referenced Nov 10, 2024
This was referenced Nov 18, 2024
This was referenced Nov 25, 2024
This was referenced Dec 2, 2024
19 tasks
21 tasks
This was referenced Jan 2, 2025
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assessment
Pull requests that affect the corresponding module
client
Pull requests that update TypeScript code. (Added Automatically!)
exercise
Pull requests that affect the corresponding module
maintainer-approved
The feature maintainer has approved the PR
programming
Pull requests that affect the corresponding module
ready to merge
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test this PR only on ts1
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Motivation and Context
We previously used individual due dates and repository locks to control when requests were sent to Athena, allowing better management of the feedback process. This has now been simplified by removing individual due dates and locks, which are no longer needed. Additionally, animations have been aligned with the default Artemis indicator for consistency. Generated feedback results are now rated by default, with a tooltip explaining that the grade is an AI assessment, subject to change. I also added sorting to the generated feedback to improve clarity.
Description
Removed the individual due date and lock mechanism for feedback requests to Athena.
Updated animations to be consistent with Artemis’ default loading indicators.
Added automatic rating of AI-generated results with a tooltip explaining that it's a preliminary grade.
Implemented sorting for generated feedback to ensure a clearer presentation of results.
Steps for Testing
Prerequisites:
1 Instructor
1 Students
1 Programming Exercise
Log in to Artemis.
Navigate to Course Administration.
Create a programming exercise, set the due date, enable manual assessment, enable grading suggestions, and select an Athena module for feedback as the instructor.
As a student, solve the programming exercise and request feedback.
Ensure the animations function as expected and that the feedback status is clearly displayed.
Verify that the feedback results can be viewed, including from the code editor.
As the instructor, set the due date to the past and assess the submission.
Ensure that the AI-generated result is no longer visible in the assessment view.
Submit the assessment, and as a student, verify that the final grade is visible.
Exam Mode Testing
Prerequisites:
1 Instructor
2 Students
1 Exam with a Programming Exercise
Log in to Artemis.
As a student, participate in the exam, solve the programming exercise, and submit.
As the instructor, assess the submission.
Ensure that the student can access the assessment without any change in functionality compared to the standard mode.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Performance Tests
Test Coverage
Info: ✅ ❌ in Confirmation (assert/expect) have to be adjusted manually, also delete trivial files!
Client
Server
Screenshots
Results timeline:
Feedback window:
Summary by CodeRabbit
Summary by CodeRabbit
Release Notes
New Features
requestFeedback
method to streamline feedback requests, improving user interaction.RequestFeedbackButtonComponent
to enhance the user experience in the code editor.Bug Fixes
Improvements