-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Allow to choose preliminary feedback model
#10067
Open
dmytropolityka
wants to merge
23
commits into
develop
Choose a base branch
from
feature/programming-exercises/choose-preliminary-feedback-model
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Programming exercises
: Allow to choose preliminary feedback model
#10067
dmytropolityka
wants to merge
23
commits into
develop
from
feature/programming-exercises/choose-preliminary-feedback-model
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules: client side
…g-exercises/choose-preliminary-feedback-model
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
database
Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
athena
Pull requests that affect the corresponding module
exercise
Pull requests that affect the corresponding module
programming
Pull requests that affect the corresponding module
text
Pull requests that affect the corresponding module
labels
Dec 23, 2024
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
dmytropolityka
changed the title
Feature/programming exercises/choose preliminary feedback model
Jan 1, 2025
Programming exercises
Allow to choose preliminary feedback model
…iminary-feedback-model
…oose-preliminary-feedback-model' into feature/programming-exercises/choose-preliminary-feedback-model
dmytropolityka
changed the title
Jan 1, 2025
Programming exercises
Allow to choose preliminary feedback modelProgramming exercises:
Allow to choose preliminary feedback model
dmytropolityka
changed the title
Jan 1, 2025
Programming exercises:
Allow to choose preliminary feedback modelProgramming exercises
: Allow to choose preliminary feedback model
github-actions
bot
added
the
core
Pull requests that affect the corresponding module
label
Jan 2, 2025
dmytropolityka
added
deploy:artemis-test1
and removed
deployment-error
Added by deployment workflows if an error occured
labels
Jan 5, 2025
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deploy:artemis-test1
labels
Jan 6, 2025
dmytropolityka
removed
the
deployment-error
Added by deployment workflows if an error occured
label
Jan 6, 2025
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deploy:artemis-test1
labels
Jan 6, 2025
zagemello
removed
the
deployment-error
Added by deployment workflows if an error occured
label
Jan 6, 2025
vinceclifford
added
deploy:artemis-test5
deploy:artemis-test1
and removed
deploy:artemis-test5
labels
Jan 6, 2025
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deployment-error
Added by deployment workflows if an error occured
labels
Jan 6, 2025
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deploy:artemis-test1
labels
Jan 6, 2025
vinceclifford
removed
the
deployment-error
Added by deployment workflows if an error occured
label
Jan 6, 2025
github-actions
bot
added
deployment-error
Added by deployment workflows if an error occured
and removed
deploy:artemis-test1
labels
Jan 13, 2025
flbrgit
removed
the
deployment-error
Added by deployment workflows if an error occured
label
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
athena
Pull requests that affect the corresponding module
client
Pull requests that update TypeScript code. (Added Automatically!)
core
Pull requests that affect the corresponding module
database
Pull requests that update the database. (Added Automatically!). Require a CRITICAL deployment.
deploy:artemis-test4
exercise
Pull requests that affect the corresponding module
modeling
Pull requests that affect the corresponding module
programming
Pull requests that affect the corresponding module
ready for review
server
Pull requests that update Java code. (Added Automatically!)
tests
text
Pull requests that affect the corresponding module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test only on TS1
!!! Contains database migrations !!!
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Changes affecting Programming Exercises
Motivation and Context
Currently, Artemis allows only one module to be set for Athena Feedback Requests, be it for preliminary or graded feedback. This PR addresses the limitation and enables setting separate modules for each type of feedback.
Description
This PR introduces functionality that allows instructors to configure different Athena Feedback Request modules for preliminary feedback and graded feedback. Preliminary feedback can now be assigned a dedicated module without affecting the graded feedback settings.
Steps for Testing
Disclaimer:
Currently, only LLM modules support preliminary feedback. You can easily test this functionality with non-LLM modules to verify if the correct module is being used (non-LLM modules will not work).
As an instructor:
2. Navigate to the course settings.
3. Create a Programming, Text, or Modeling exercise.
4. Select a module for preliminary feedback (no due date required). For graded feedback, enable Feedback Suggestions, set a due date, and select a module(text or programming).
5. Save the changes.
As a student:
6. Open the created exercise.
7. Submit something.
8. Submit an AI feedback request.
9. Verify that the appropriate module is used based on the type of feedback.
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Performance Tests
Screenshots
Summary by CodeRabbit
Release Notes
New Features
ModuleType
enum withFEEDBACK_SUGGESTIONS
andPRELIMINARY_FEEDBACK
constants.Improvements
Changes
allowFeedbackRequests
toallowManualFeedbackRequests
.feedbackSuggestionModule
andpreliminaryFeedbackModule
to exercises.Localization
These changes provide more flexible and precise feedback mechanisms across different exercise types.