Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Unify json usage #7457

Merged
merged 13 commits into from
Oct 29, 2023

fix remaining server test

c5aeab3
Select commit
Loading
Failed to load commit list.
Merged

Development: Unify json usage #7457

fix remaining server test
c5aeab3
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Teamscale / teamscale-findings required action Oct 28, 2023 in 0s

Teamscale

This pull request would introduce 3 new findings

Details

Teamscale's logo 3 added, 8 in changed code, 0 removed 46 Test Gaps (100%) tested changes: 0|untested changes: 36|untested additions: 10

  • src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13LaunchRequest.java#29: Avoid using ternary operators (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13AgsClaim.java#25: Avoid using ternary operators (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13AgsClaim.java#7: Star import of com.google.gson.* should not be used (view in Teamscale)

Annotations

Check warning on line 29 in src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13LaunchRequest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13LaunchRequest.java#L29

Avoid using ternary operators
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2Fconsistent-json-usage%3AHEAD&id=8BA177BE10F2086EF75AE1627E5A0602

Check warning on line 7 in src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13AgsClaim.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13AgsClaim.java#L7

Star import of `com.google.gson.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2Fconsistent-json-usage%3AHEAD&id=0B4C2722500E2A7B18C1A995A34CB2A7

Check warning on line 25 in src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13AgsClaim.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/domain/lti/Lti13AgsClaim.java#L25

Avoid using ternary operators
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=chore%2Fconsistent-json-usage%3AHEAD&id=FF05CB6190F0F2CB38A38709E368C523