Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Unify json usage #7457

Merged
merged 13 commits into from
Oct 29, 2023
Merged

Development: Unify json usage #7457

merged 13 commits into from
Oct 29, 2023

Conversation

basak-akan
Copy link
Contributor

@basak-akan basak-akan commented Oct 28, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.

Motivation and Context

Currently, different JSON implementations are used.

Description

Unified Json implementations to use gson library. Also some of the JsonParser implementations are replaced with ObjectMapper. Added an architectural test to prevent the use of other user libraries in the future.

Steps for Testing

Prerequisites:

  • Please use test server 11 where LTI is enabled
  1. Log in to https://moodle.ase.in.tum.de/ using username: student1 and password: as same password with artemis_test_user_1
  2. Navigate to LTI Testing course and select TS11 Authentication Test Exercise.
  3. Login to Artemis using artemis_test_user_1 credentials.
  4. Verify you can see the exercise and participate in the exercise.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

no change in test coverage since only replaced Json implementations.

Screenshots

@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Oct 28, 2023
@basak-akan basak-akan marked this pull request as ready for review October 28, 2023 09:46
@basak-akan basak-akan requested a review from a team as a code owner October 28, 2023 09:46
tobias-lippert
tobias-lippert previously approved these changes Oct 28, 2023
Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

julian-christl
julian-christl previously approved these changes Oct 28, 2023
Copy link
Member

@julian-christl julian-christl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

server tests currently fail with a NullPointerException.

@julian-christl julian-christl dismissed their stale review October 28, 2023 18:14

failing tests

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@krusche krusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 thank you

@krusche krusche added this to the 6.6.3 milestone Oct 29, 2023
@krusche krusche merged commit 5eb76d0 into develop Oct 29, 2023
23 of 27 checks passed
@krusche krusche deleted the chore/consistent-json-usage branch October 29, 2023 18:03
@krusche krusche changed the title Development: Unify Json usage Development: Unify json usage Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ready for review server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants