Development: Replace usage of standard streams with logger calls

src/main/java/de/tum/in/www1/artemis/config/BeanInfoProcessor.java

@@ -17,6 +17,9 @@
 import javax.tools.Diagnostic.Kind;
 import javax.tools.JavaFileObject;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.google.auto.service.AutoService;
 
 // TODO this is not working yet
@@ -25,12 +28,14 @@
 @SupportedSourceVersion(SourceVersion.RELEASE_17)
 public class BeanInfoProcessor extends AbstractProcessor {
 
+    private final Logger log = LoggerFactory.getLogger(BeanInfoProcessor.class);
+
     @Override
     public boolean process(Set<? extends TypeElement> annotations, RoundEnvironment roundEnv) {
         for (TypeElement annotation : annotations) {
             Set<? extends Element> annotatedElements = new HashSet<>(roundEnv.getElementsAnnotatedWith(annotation));
             annotatedElements.stream().filter(ele -> ele.getKind().isClass()).map(ele -> (TypeElement) ele).flatMap(ele -> findSupers(ele).stream())
-                    .forEach(ele -> generateBeanInfo((TypeElement) ele));
+                    .forEach(ele -> generateBeanInfo(ele));
         }
         return false;
     }
@@ -69,7 +74,7 @@ private void generateBeanInfo(TypeElement typeElement) {
             processingEnv.getMessager().printMessage(Kind.WARNING, "Cannot create " + beanInfoFQN + ", maybe it already exists?");
         }
         catch (IOException e) {
-            e.printStackTrace();
+            log.error("Error while generating bean info", e);
             processingEnv.getMessager().printMessage(Kind.ERROR, "IO exception");
         }
     }

src/main/java/de/tum/in/www1/artemis/domain/ProgrammingExercise.java

@@ -478,7 +478,7 @@ public VcsRepositoryUrl getVcsTemplateRepositoryUrl() {
             return new VcsRepositoryUrl(templateRepositoryUrl);
         }
         catch (URISyntaxException e) {
-            e.printStackTrace();
+            log.warn("Cannot create URI for templateRepositoryUrl: {} due to the following error: {}", templateRepositoryUrl, e.getMessage());
         }
         return null;
     }
@@ -499,7 +499,7 @@ public VcsRepositoryUrl getVcsSolutionRepositoryUrl() {
             return new VcsRepositoryUrl(solutionRepositoryUrl);
         }
         catch (URISyntaxException e) {
-            e.printStackTrace();
+            log.warn("Cannot create URI for solutionRepositoryUrl: {} due to the following error: {}", solutionRepositoryUrl, e.getMessage());
         }
         return null;
     }

src/main/java/de/tum/in/www1/artemis/domain/participation/ProgrammingExerciseParticipation.java

@@ -70,7 +70,7 @@ default VcsRepositoryUrl getVcsRepositoryUrl() {
             return new VcsRepositoryUrl(repoUrl);
         }
         catch (URISyntaxException e) {
-            e.printStackTrace();
+            log.warn("Cannot create URI for repositoryUrl: {} due to the following error: {}", repoUrl, e.getMessage());
         }
         return null;
     }

src/test/java/de/tum/in/www1/artemis/ArchitectureTest.java

@@ -20,6 +20,7 @@
 import com.tngtech.archunit.base.DescribedPredicate;
 import com.tngtech.archunit.core.domain.*;
 import com.tngtech.archunit.lang.*;
+import com.tngtech.archunit.library.GeneralCodingRules;
 
 import de.tum.in.www1.artemis.service.WebsocketMessagingService;
 
@@ -96,6 +97,16 @@ void testFileWriteUsage() {
         usage.check(allClasses);
     }
 
+    @Test
+    void testLogging() {
+        GeneralCodingRules.NO_CLASSES_SHOULD_USE_JAVA_UTIL_LOGGING.check(allClasses);
+
+        // We currently need to access standard streams in readTestReports() to use the SurefireReportParser
+        // The ParallelConsoleAppender is used to print test logs to the console (necessary due to parallel test execution)
+        var classes = allClasses.that(not(simpleName("ProgrammingExerciseTemplateIntegrationTest").or(simpleName("ParallelConsoleAppender"))));
+        GeneralCodingRules.NO_CLASSES_SHOULD_ACCESS_STANDARD_STREAMS.check(classes);
+    }
+
     // Custom Predicates for JavaAnnotations since ArchUnit only defines them for classes
 
     private DescribedPredicate<? super JavaAnnotation<?>> simpleNameAnnotation(String name) {

src/test/java/de/tum/in/www1/artemis/connector/BitbucketRequestMockProvider.java

@@ -15,6 +15,8 @@
 import org.hamcrest.BaseMatcher;
 import org.hamcrest.Description;
 import org.hamcrest.Matchers;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.beans.factory.annotation.Value;
@@ -47,6 +49,8 @@
 @Profile("bitbucket")
 public class BitbucketRequestMockProvider {
 
+    private final Logger log = LoggerFactory.getLogger(BitbucketRequestMockProvider.class);
+
     @Value("${artemis.version-control.url}")
     private URL bitbucketServerUrl;
 
@@ -301,7 +305,7 @@ public boolean matches(Object actual) {
                                 return actual.equals(mapper.writeValueAsString(body));
                             }
                             catch (JsonProcessingException e) {
-                                e.printStackTrace();
+                                log.warn("Error while parsing", e);
                                 return false;
                             }
                         }

src/test/java/de/tum/in/www1/artemis/exercise/modelingexercise/ModelingExerciseUtilService.java

@@ -3,6 +3,7 @@
 import static com.google.gson.JsonParser.parseString;
 import static org.assertj.core.api.Assertions.assertThat;
 
+import java.io.IOException;
 import java.time.ZonedDateTime;
 import java.util.*;
 
@@ -269,7 +270,7 @@ public Submission addModelingSubmissionWithFinishedResultAndAssessor(ModelingExe
         return participationUtilService.addSubmissionWithFinishedResultsWithAssessor(participation, submission, assessorLogin);
     }
 
-    public ModelingSubmission addModelingSubmissionFromResources(ModelingExercise exercise, String path, String login) throws Exception {
+    public ModelingSubmission addModelingSubmissionFromResources(ModelingExercise exercise, String path, String login) throws IOException {
         String model = FileUtils.loadFileFromResources(path);
         ModelingSubmission submission = ParticipationFactory.generateModelingSubmission(model, true);
         submission = addModelingSubmission(exercise, submission, login);

src/test/java/de/tum/in/www1/artemis/participation/SubmissionExportIntegrationTest.java

@@ -96,8 +96,8 @@ void initTestCase() {
                     modelingSubmission3 = modelingExerciseUtilService.addModelingSubmissionFromResources(modelingExercise, "test-data/model-submission/model.54745.json",
                             TEST_PREFIX + "student3");
                 }
-                catch (Exception e) {
-                    e.printStackTrace();
+                catch (IOException e) {
+                    fail(e.getMessage(), e);
                 }
             }
             else if (exercise instanceof TextExercise) {

src/test/java/de/tum/in/www1/artemis/util/GitUtilService.java

@@ -83,7 +83,7 @@ public void initRepo(String defaultBranch) {
             remoteGit.close();
         }
         catch (IOException | GitAPIException ex) {
-            ex.printStackTrace();
+            fail(ex.getMessage(), ex);
         }
     }