Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Replace usage of standard streams with logger calls #7399

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

Strohgelaender
Copy link
Contributor

@Strohgelaender Strohgelaender commented Oct 16, 2023

Checklist

General

Motivation and Context

We should not directly use System.out.println() and instead use a logger to make sure the messages are correctly saved into the log file.

Description

Added a new ArchUnit test and replaces all issues found by the test case.

Steps for Testing

code review

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Oct 16, 2023
@Strohgelaender Strohgelaender marked this pull request as ready for review October 16, 2023 17:15
@Strohgelaender Strohgelaender requested a review from a team as a code owner October 16, 2023 17:15
tobias-lippert
tobias-lippert previously approved these changes Oct 16, 2023
Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@tobias-lippert
Copy link
Contributor

Reapprove

Copy link
Member

@bensofficial bensofficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me 👍

Copy link
Contributor

@tobias-lippert tobias-lippert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

Copy link
Contributor

@valentin-boehm valentin-boehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

Copy link
Contributor

@DominikRemo DominikRemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 🚀

@krusche krusche merged commit c3e3662 into develop Oct 21, 2023
27 of 31 checks passed
@krusche krusche deleted the chore/standard-out branch October 21, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants