Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Fix failing example test in Java blackbox exercise template #7365

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

b-fein
Copy link
Contributor

@b-fein b-fein commented Oct 13, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite). n/a
  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

As noted by @DominikRemo in #7359, a test case is failing for the solution repository when creating a new exercise from the Java Dejagnu/Blackbox template.

Description

Fixes the line length checks (max. 80 characters allowed per line) by reformatting the offending lines.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • Server with Jenkins CI system (e.g. TS2)
  1. Create a new Java programming exercise of type blackbox/dejagnu.
  2. The solution build should not fail any test cases.
  3. Until Programming exercises: Update dependencies for Java blackbox exercise template #7359 is merged, you might have to update the pom.xml in the Tests repository to change the Java release from 20 to 21.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Test Coverage

n/a

@b-fein b-fein added small bugfix stacked-pr PR that depends on another PR labels Oct 13, 2023
@b-fein b-fein added this to the 6.6.0 milestone Oct 13, 2023
@b-fein b-fein marked this pull request as ready for review October 13, 2023 05:57
@b-fein b-fein requested a review from a team as a code owner October 13, 2023 05:57
@b-fein b-fein force-pushed the fix/blackbox-tests-line-length branch from 5014488 to b96fdd0 Compare October 13, 2023 05:58
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would look a bit cleaner if code blocks were uses for all cases, not just a few selected.

DominikRemo
DominikRemo previously approved these changes Oct 13, 2023
Copy link
Contributor

@DominikRemo DominikRemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts2. All six tests now pass in the solution build.
Thank you for the fix 🚀

Base automatically changed from fix/update-deps-maven-blackbox to develop October 14, 2023 07:00
@krusche krusche dismissed DominikRemo’s stale review October 14, 2023 07:00

The base branch was changed.

@krusche krusche merged commit dd9c923 into develop Oct 14, 2023
16 of 21 checks passed
@krusche krusche deleted the fix/blackbox-tests-line-length branch October 14, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants