Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises: Update dependencies for Java blackbox exercise template #7359

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

b-fein
Copy link
Contributor

@b-fein b-fein commented Oct 11, 2023

Checklist

General

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

In the last update #7127 we forgot to update the Java version in the pom.xml of the tests repository.

Description

Updates the Java version to 21 to match the template solution and exercise repositories.
Uses this occasion to also update plugins specified in the pom.xml.

Steps for Testing

Prerequisites:

  • 1 Instructor
  1. Create a new Java programming exercise of type Dejagnu/Blackbox.
  2. The solution build passes all tests, the template build none.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@b-fein b-fein marked this pull request as ready for review October 11, 2023 17:27
@b-fein b-fein requested a review from a team as a code owner October 11, 2023 17:27
@b-fein b-fein requested a review from chrisknedl October 11, 2023 17:27
@Strohgelaender
Copy link
Contributor

Do you provide these dependencies within your docker image? If yes, we should probably update the image version as well.

@b-fein
Copy link
Contributor Author

b-fein commented Oct 12, 2023 via email

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Copy link
Member

@Hialus Hialus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Copy link
Contributor

@DominikRemo DominikRemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ts2. Works as expected.

Note: One test fails for the solution build. It's unrelated to this PR but we should at least write an Issue once this PR gets merged. Edit: fixed in #7365

@b-fein b-fein added this to the 6.6.0 milestone Oct 13, 2023
@krusche krusche merged commit 175ab18 into develop Oct 14, 2023
53 of 56 checks passed
@krusche krusche deleted the fix/update-deps-maven-blackbox branch October 14, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants