Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lectures: Show slide numbers to be removed in automatic unit processing #7350

Merged
merged 14 commits into from
Nov 3, 2023

fixed an issue with a duplicated endpoint

ed9e3fa
Select commit
Loading
Failed to load commit list.
Merged

Lectures: Show slide numbers to be removed in automatic unit processing #7350

fixed an issue with a duplicated endpoint
ed9e3fa
Select commit
Loading
Failed to load commit list.
Teamscale / teamscale-findings required action Oct 30, 2023 in 0s

Teamscale

This pull request would introduce 18 new findings

Details

Teamscale's logo 18 added, 8 in changed code, 7 removed 32 Test Gaps (100%) tested changes: 0|untested changes: 14|untested additions: 18

  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#171: Method getAttachmentUnitsData_asInstructor_shouldGetUnitsInformation violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#221: Method createAttachmentUnits_asInstructor_shouldCreateAttachmentUnits violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java#28: Star import of de.tum.in.www1.artemis.service.* should not be used (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#104: Method testAll_LectureWithoutCourse_shouldReturnConflict violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#292: Method createAttachmentUnits_asInstructor_shouldThrowError violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#1: Violation of file size threshold (source lines of code) of 300: 311 (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java#190: Exception stacktrace is lost (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#248: Method createAttachmentUnits_asInstructor_shouldRemoveSlides violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#161: Violation of nesting depth threshold of 3: 4 (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#136: Method testAll_IOException_ShouldReturnInternalServerError violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#163: Method uploadSlidesForProcessing_asInstructor_shouldThrowError violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#209: Method getSlidesToRemove_asInstructor_shouldThrowError violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#131: Violation of nesting depth threshold of 3: 4 (view in Teamscale)
  • src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java#31: Star import of de.tum.in.www1.artemis.web.rest.errors.* should not be used (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#194: Method getSlidesToRemove_asInstructor_shouldGetUnitsInformation violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#118: Method testAll_WrongLecture_shouldReturnNotFound violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#184: Method getAttachmentUnitsData_asInstructor_shouldThrowError violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)
  • src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#154: Method uploadSlidesForProcessing_asInstructor_shouldGetFilename violates naming convention. Should be one of [a-z][a-zA-Z0-9]* (view in Teamscale)

Annotations

Check warning on line 184 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L184 

Method `getAttachmentUnitsData_asInstructor_shouldThrowError` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=182805930C0CA7D843CBC4C68DDAA4B1

Check warning on line 171 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L171 

Method `getAttachmentUnitsData_asInstructor_shouldGetUnitsInformation` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=1F00D623F4BD5158128348835ECF0C4C

Check warning on line 1 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L1 

Violation of file size threshold (source lines of code) of 300: 311
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=2AD6BD0823F16DB68EE24CAAC582E1A5

Check warning on line 221 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L221 

Method `createAttachmentUnits_asInstructor_shouldCreateAttachmentUnits` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=321B91B560B5AED5006C2B74F7336DFA

Check warning on line 118 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L118 

Method `testAll_WrongLecture_shouldReturnNotFound` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=518AC64AB99BCE0867B0D260C4662D6C

Check warning on line 248 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L248 

Method `createAttachmentUnits_asInstructor_shouldRemoveSlides` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=5F0A53F5006967A08E79F087697FDFC9

Check warning on line 136 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L136 

Method `testAll_IOException_ShouldReturnInternalServerError` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=61DF8F27444BA132B35323FFD19510AA

Check warning on line 154 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L154 

Method `uploadSlidesForProcessing_asInstructor_shouldGetFilename` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=6290684E9F108FA33B4C25105D233F36

Check warning on line 104 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L104 

Method `testAll_LectureWithoutCourse_shouldReturnConflict` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=78E30654F0903BF0EEDA74952B9C96EA

Check warning on line 209 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L209 

Method `getSlidesToRemove_asInstructor_shouldThrowError` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=BFC22CF770C2CA84E008C3877E780E67

Check warning on line 163 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L163 

Method `uploadSlidesForProcessing_asInstructor_shouldThrowError` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=C69FEBF29E778504C1810CBF4AA46788

Check warning on line 292 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L292 

Method `createAttachmentUnits_asInstructor_shouldThrowError` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=E323E7EDCE3EE1802FA41B160C62C688

Check warning on line 194 in src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/test/java/de/tum/in/www1/artemis/lecture/AttachmentUnitsIntegrationTest.java#L194 

Method `getSlidesToRemove_asInstructor_shouldGetUnitsInformation` violates naming convention. Should be one of `[a-z][a-zA-Z0-9]*`
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=F8799D09B0202C0960FAC41278373AD9

Check warning on line 31 in src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java#L31 

Star import of `de.tum.in.www1.artemis.web.rest.errors.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=27BB41E8E13EB31A5AA588101E5888DE

Check warning on line 190 in src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java#L190 

Exception stacktrace is lost
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=7D0E03643DBA8CD7E9A5EC52EE4838B2

Check warning on line 28 in src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java#L28 

Star import of `de.tum.in.www1.artemis.service.*` should not be used
https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=B51213DBBDCCDFD0E8DA09036C8A372D

Check warning on line 161 in src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#L161 

This method is slightly nested [0]. Consider extracting helper methods or reducing the nesting by using early breaks or returns.

[0] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=3EE5AAED06D6E2A4E8B4F1AA8679149F

Check warning on line 131 in src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java

See this annotation in the file changed.

@teamscale teamscale / teamscale-findings

src/main/java/de/tum/in/www1/artemis/service/LectureUnitProcessingService.java#L131 

This method is slightly nested [0]. Consider extracting helper methods or reducing the nesting by using early breaks or returns.

[0] https://teamscale.io/findings.html#details/GitHub-ls1intum-Artemis?t=feature%2Flecture%2Fshow-removed-slide-numbers%3AHEAD&id=600005BDFAF82F7EFF2C5ADC022E6359
View more details on Teamscale