-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lectures
: Show slide numbers to be removed in automatic unit processing
#7350
Conversation
src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java
Fixed
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java
Fixed
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java
Fixed
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/web/rest/lecture/AttachmentUnitResource.java
Fixed
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on ts1, works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested during testing session, worked well
❌ Unable to deploy to test servers ❌The docker build needs to run through before deploying. |
…github.com/ls1intum/Artemis into feature/lecture/show-removed-slide-numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested locally. Works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts1 in testing session. Works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Testing session on TS3 - LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested during testing session
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
Lecture
: Show slide numbers to be removed in automatic unit processingLectures
: Show slide numbers to be removed in automatic unit processing
Checklist
General
Server
Client
Motivation and Context
Solves Issue #6896
Description
When adding attachment units to a lecture via automatic lecture processing, users can remove slides with certain keywords (e.g. "Break"). This PR adds the functionality that when the user searches for keywords, the slides that will be removed get displayed.
Steps for Testing
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client
Server
Screenshots