Programming exercises: Add server support for feedback suggestions

[pal03377]

Warning

This PR includes a migration! Do not deploy to a normal test server. Instead, use ma-schwind.ase.cit.tum.de.

Feature proposal: #7094

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I followed the coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
• I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
• I documented the Java code using JavaDoc style.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I followed the coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
• I documented the TypeScript code using JSDoc style.
• I added multiple screenshots/screencasts of my UI changes.
• I translated all newly inserted strings into English and German.

Motivation and Context

We want to actually show feedback suggestions from Athena in the programming exercise tutor assessment editor.

Description

• I generalized the server code to work for more types of specific exercises, namely text and programming exercises.
• I added support for sending structured grading instructions to Athena and receiving them from Athena.
• I adapted the client code as needed to receive the feedback suggestions from the server.

Steps for Testing

Prerequisites:

• 1 Programming/Text exercise, each with at least one submission. The programming exercise has to be set up for manual assessment (has a due date and is switched from "automatic" to "manual" assessment on the settings page)
• 1 Instructor
• 1 Tutor
• Deployment of Athena#125 with GitHub label like in Artemis

Pre-configured example exercises: https://ma-schwind.ase.cit.tum.de/courses/7/exercises

1. As an instructor, go to the settings page of each exercise and ensure that you can turn on the option for "Athena feedback suggestions". It should be disabled for programming exercises with automatic assessment: You can enable it by choosing manual assessment for the exercise.
2. As a tutor (or still instructor), go to the exercise with the existing submissions
3. Go to the assessment dashboard and start assessing a submission.
4. You should see feedback suggestions.
5. Test that the suggestions behave like the following:

• For text exercises, the suggestion is automatically applied. You can edit or delete it.
• For programming exercises, the suggestions are visible with lightbulbs in the sidebar of the editor. You can accept them or reject them. After accepting, you can modify them.
• If you have a programming exercise feedback suggestion that is neither accepted nor rejected: When you submit, there is a confirmation dialog to confirm that you dismiss all pending suggestions.

(New) The first referenced test feedback will be associated with a grading instruction.

After testing, ask Paul to look into the Artemis+Athena server logs to confirm that there were no new problems with submission sending, feedback sending, and submission selection either.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Client

Class/File	Line Coverage	Confirmation (assert/expect)
athena.service.ts	91.83%	✅
unreferenced-feedback-detail.component.ts	100%	✅
code-editor-tutor-assessment-container.component.ts	87.03%	✅ improved from 86.81% on develop
code-editor-ace.component.ts	84.78%	✅ improved from 83.39% on develop
feedback-suggestion-badge.component.ts	100%	✅
feedback-suggestions-pending-confirmation-dialog.component.ts	50%	The component contains no logic that can be tested
unreferenced-feedback.component.ts	96.61%	✅
text-submission-assessment.component.ts	90.82%	✅
text-exercise-update.component.ts	86.27%	✅ increased from 84.61% on develop

Server

Class/File	Line Coverage	Confirmation (assert/expect)
TextSubmissionService.java	88%	✅ same as on develop
AthenaDTOConverter.java	81%	✅ only exceptions that should never happen are untested
AthenaFeedbackSendingService.java	94%	✅
AthenaFeedbackSuggestionsService.java	100%	✅
AthenaModuleUrlHelper.java	76%	✅ Only an exception that should never happen is untested
AthenaRepositoryExportService.java	92%	✅
AthenaSubmissionSelectionService.java	100%	✅
AthenaSubmissionSendingService.java	92%	✅
AthenaScheduleService.java	44%	kept as before
AthenaResource.java	77%	✅ ❌
ProgrammingAssessmentResource.java	89%	✅ Up from 88% on develop
TextAssessmentResource.java	90%	✅

Screenshots

Suggestions in Text Exercise (looks a bit weird because I hardcoded the suggestion index ranges to better test):

Suggestions in Programming Exercise:

Confirmation if there are pending feedback suggestions (programming exercises only):

[egekurt123]

Tested at a testing session, works as expected

[vinceclifford]

Works as expected. Tested during testing session

[basak-akan]

Tested during the testing session, worked well.

[florian-glombik]

Tested on https://ma-schwind.ase.cit.tum.de/course-management/7/text-exercises/35 and worked fine!

• suggestions are displayed for programming and text exercises
• when disabling suggestions there are no errors displayed for the text exercises
• suggestions can be applied and rejected

Only a small comment (no need to change it now): I think that Delete and the trash bin is a quite strong wording - so I would either directly apply the suggestions to programming exercises (similar to the text exercises) or make the wording less strong

[laurenzfb]

Tested in testing session. Found everything working as described!

[maximiliansoelch]

Code looks good after the latest commit.
Just found some minor copy & paste mistakes in the comments that can be corrected in a follow up

[maximiliansoelch]

Suggested change

	/**
	* Create a new TextExerciseDTO from a TextExercise
	*/
	/**
	* Create a new ProgrammingExerciseDTO from a ProgrammingExercise
	*/

[maximiliansoelch]

Copy & paste mistake:

Suggested change

	* Creates a TextFeedbackDTO from a Feedback object
	*
	* @param exerciseId the id of the exercise the feedback is given for
	* @param submissionId the id of the submission the feedback is given for
	* @param feedback the feedback object
	* @return the TextFeedbackDTO
	* Creates a ProgrammingFeedbackDTO from a Feedback object
	*
	* @param exerciseId the id of the exercise the feedback is given for
	* @param submissionId the id of the submission the feedback is given for
	* @param feedback the feedback object
	* @return the ProgrammingFeedbackDTO