Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Only load AthenaModuleUrlHelper with respective Spring Profile #7669

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

reschandreas
Copy link
Contributor

@reschandreas reschandreas commented Nov 25, 2023

Checklist

General

Motivation and Context

The PR #7136 introduced a new Bean that the application tried to load it, even without the correct profile. If the configuration is not there, Artemis can't start.

Description

I added the Spring annotation

Steps for Testing

Prerequisites:

  • Test server/Local setup
  1. Deploy Artemis on develop or a PR rebased on develop today (shamelessly plugging my PR Development: Add Aeolus to support custom build plans for programming exercises #7642) and observe that it can't start due to the missing URL logs here
  2. Deploy/start artemis somewhere where ${artemis.athena.url} (TS1 for example) is not specified and check if Artemis starts.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

@reschandreas reschandreas requested a review from a team as a code owner November 25, 2023 15:00
@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Nov 25, 2023

This comment was marked as outdated.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Nov 25, 2023
@github-actions github-actions bot removed the deployment-error Added by deployment workflows if an error occured label Nov 25, 2023
@reschandreas reschandreas temporarily deployed to artemis-test1.artemis.cit.tum.de November 25, 2023 15:11 — with GitHub Actions Inactive
@reschandreas reschandreas changed the title Development: Load AthenaModuleUrlHelper only with respective Spring Profile Development: Only load AthenaModuleUrlHelper with respective Spring Profile Nov 25, 2023
@pal03377 pal03377 temporarily deployed to artemis-test1.artemis.cit.tum.de November 25, 2023 16:00 — with GitHub Actions Inactive
Copy link
Contributor

@pal03377 pal03377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix! I tested deploying on TS1 and reviewed the code. Everything works as expected and looks good.

@krusche krusche added this to the 6.7.0 milestone Nov 25, 2023
@krusche krusche merged commit 9741a28 into develop Nov 25, 2023
67 of 72 checks passed
@krusche krusche deleted the bugfix/load-athena-only-with-spring-profile branch November 25, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Pull requests that update Java code. (Added Automatically!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants