Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Darjeeling #59

Merged
merged 34 commits into from
Apr 8, 2024
Merged

Update Darjeeling #59

merged 34 commits into from
Apr 8, 2024

Conversation

rivos-eblot
Copy link

  • Mailboxes should only have access to dedicated Mailbox SRAM
  • Dev Proxy: enumerated device may have longer descriptor names
  • JTAG: add an option to disable remote termination of QEMU VM
  • JTAG: add initial documentation
  • RISC-V DM: code clean up and fix bugs
  • RISC-V DM: enable astractauto feature. Note: OpenOCD is buggy and always consider this feature is available.
  • PinMux: add initial support for GPIO: pull up/down/opendrain/...
  • GPIO: add IRQ to enable I/O connections
  • GPIO + PwrMgr: add "HW strap" read out @ startup
  • scripts: add a new scripts to exercise & test GPIO
  • SPI data flash: add Resettable API and optional HW reset GPIO

@rivos-eblot
[ot] hw/opentitan: ot_mbx: add a dedicated address space for RAM
3391311 
HW implementation restricts MBOX memory to the MBOX SRAM. All other locations
on the cross bar cannot be reached from the MBOX controller.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: ot_darjeeling.c: configure MBOX to use reserved MBOX SRAM
8fae94e 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/misc: pulp_rv_dm.c: shorten Pulp DM memory region names
909c40d 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_dev_proxy.c: rework device enumeration
6a5a7ef 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] jtag: jtag_bitbang.c: add an option to manage remote VM termination
558fe6c 
`quit=[on|off]` can be used with `-jtag` option to enable or disable VM
termination on JTAG request.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: dm.c: command errors should not be propagated as DMI e…
4995bbe 
…rror

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: dm.c: add DM name to all trace messages
10305f2 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: dm.c: disable left-over debug trace
f8b9202 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: dm.c: simplify trace message masking
1526657 
Also improve AARSIZE error reporting.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: dm.c: register on DTM on realization, not on reset.
ea79962 
This enables DM discovery even if the parent subsystem has not been
reset.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: dm.c: code cleanup, add a new trace
c818978 
Enable abstractauto by default.
Beware that current version of OpenOCD (2024/04) assumes this feature
is always supported.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot]: hw/riscv: OpenTitan RISC-V DM support abstractauto feature.
558bdbb 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] docs/opentitan: add initial documentation for JTAG Debug Module
b99e33b 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] scripts/opentitan: OpenOCD: update darjeeling config file
d941d4d 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: add a new API for IbexIRQ initialization.
590fcb9 
Factorize a bit existing code.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_pinmux: add IbexIRQs to manage pad config
204434d 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_pinmux: rework to support pinmux variants
34c74bf 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_gpio: implement I/O as IbexIRQs
37f8d77 
Add initial support for Pinmux

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_gpio: rework to support gpio variants
b4d3a29 
This also reverts commit 266a493 for
the Earlgrey version.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: remove useless header file inclusions
8e9be80 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_gpio_dj: add HW strap support
dc1091a 
+ fix issues from 266a493

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_pwrmgr: add HW strap sampling
519bb5f 
+ fix invalid state ordering in fast FSM

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: ot_darjeeling: connect HW strap signal from PwrMgr to …
61f1899 
…GPIO

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: ot_gpio: add support for PinMux and GPIO output
55660ea 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] scripts/opentitan: update Treillis script with new GPIO features.
966330f 
- Hi-Z support
- Pull up/down settings
- Remote-triggered wipe

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] scripts/opentitan: add new gpiodev.py script to exercise GPIO
35f940f 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/block: m25p80.c: implement Resettable API for SPI flash devices.
3072007 
Resettable API enables holding SPI flash device in reset if a reset pin
is asserted. When the SPI flash device is held in reset, it should ignore
SPI transfer and /CS signal.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/block: m25p80.c: add a "RESET#" input GPIO to manage HW reset
c1d5ce7 
When the SPI flash device is held in reset, it ignores SPI transfers and
/CS signal.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: dtm: add a sanity check for registering DMs
3229806 
DM registration can only be done once DTM has been realized.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: dm: register on DTM while resetting
f18c2ad 
This enables realizing DTM and DM in any order. It is ok to register
the same DM more than once, this action is simply ignored.

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/riscv: ot_darjeeling: fix DMI base address of RV DM
cce452a 
Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] hw/opentitan: jtag_bitbang: use info_report rather than qemu_log
4267bca 
... to report termination information

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] scripts/opentitan: pyot.py: fix invalid execution time with ext.…
d27e05f 
… commands

Signed-off-by: Emmanuel Blot <[email protected]>
@rivos-eblot
[ot] scripts/opentitan: pyot.py: improve & factorize log message reports
4d9aca6 
Signed-off-by: Emmanuel Blot <[email protected]>
loiclefort
loiclefort approved these changes Apr 8, 2024
View reviewed changes
Copy link

@loiclefort loiclefort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (already reviewed and tested at Rivos)

@rivos-eblot rivos-eblot merged commit c35be8a into lowRISC:ot-darjeeling-8.2.0 Apr 8, 2024
5 checks passed
@rivos-eblot rivos-eblot deleted the dev/ebl/dj_update branch April 9, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loiclefort loiclefort loiclefort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivos-eblot @loiclefort