[otbn/tvla] Add batch mode for OTBN vertical ecc256 keygen capture #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wettermo
requested review from
abdullahvarici,
alphan,
andreaskurth,
vogelpi and
vrozic
as code owners
wettermo
force-pushed
the
otbn-vertical-batch-pr
branch
from
ff2b8be
to
701a8e8
Compare
vrozic
reviewed
Mar 3, 2023
vrozic
reviewed
Mar 3, 2023
Signed-off-by: Moritz Wettermann <[email protected]>
wettermo
force-pushed
the
otbn-vertical-batch-pr
branch
from
701a8e8
to
c49564f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
The batch mode increases the capture rate, compared to non-batch mode, by approx. 2000% (at least on my FPGA setup). (Before: ca. 20 Traces/s, Now: ca. 400 Traces/s)
First TVLA results look good: (first plot: masks off, 10k traces, second plot: masks on, 40k traces)
Once the corresponding PR for the serial device code (lowRISC/opentitan#17416) is merged I'll open another PR for the built binary.