Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sw/sca] Add batch mode for ecc256 keygen serial file #17416

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

wettermo
Copy link
Contributor

@wettermo wettermo commented Mar 1, 2023

This commit / PR

  • Adds a command handler to set a signal value whether masking should be enabled/disabled for secret keygen in batch mode
  • Adds a command handler for the batch mode itself
  • Corrects two minor commentary mistakes

The binary that can be built from this code is required for capturing traces in batch mode for OTBN ecc256 keygen vertical TVLA analysis.

@wettermo wettermo requested a review from a team as a code owner March 1, 2023 15:43
@wettermo wettermo requested review from moidx, jadephilipoom, m-temp, abdullahvarici, bilgiday, vogelpi, vrozic and a team and removed request for a team March 1, 2023 15:43
@moidx moidx removed the request for review from a team March 1, 2023 15:47
sw/device/sca/ecc256_keygen_serial.c Show resolved Hide resolved
sw/device/sca/ecc256_keygen_serial.c Show resolved Hide resolved
sw/device/sca/ecc256_keygen_serial.c Outdated Show resolved Hide resolved
sw/device/sca/ecc256_keygen_serial.c Show resolved Hide resolved
sw/device/sca/ecc256_keygen_serial.c Outdated Show resolved Hide resolved
sw/device/sca/ecc256_keygen_serial.c Show resolved Hide resolved
@wettermo
Copy link
Contributor Author

wettermo commented Mar 2, 2023

We just discussed in the SCA WG meeting that I, for now, should only address the objections relevant to this individual batch mode implementation. This allows us to progress faster with the actual TVLA analysis. For all the other issues, which concern the other batch modes too, I will open up an issue in the OT repository, so that the comments @jadephilipoom made won't get lost. Thanks for the extensive review @jadephilipoom !

Adds a command handler to set a signal value whether masking should be
enabled/disabled for secret keygen in batch mode

Adds a command handler for the batch mode itself

Signed-off-by: Moritz Wettermann <[email protected]>
@wettermo
Copy link
Contributor Author

wettermo commented Mar 3, 2023

I now also opened A PR in the ot-sca repository, which adds the corresponding batch mode capture function.
lowRISC/ot-sca#128

Copy link
Contributor

@vogelpi vogelpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wettermo !

@vrozic also wanted to review this, let's wait for his feedback, too.

Copy link
Contributor

@vrozic vrozic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wettermo for working on this and for opening the issue #17441.
This looks good to me.

@vogelpi
Copy link
Contributor

vogelpi commented Mar 6, 2023

I am merging this PR despite the "Earl Grey SW Build & Test" currently fails. The failure is due to the step timing out. A PR to increase the timout is under way (see #17440). However, this PR here doesn't change any software that is run in CI or on the Verilated platform. Instead, the SCA-related binaries are just compiled and there are no compilation failures. It is thus safe to merge this PR here.

@vogelpi vogelpi merged commit 894278f into lowRISC:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants