Allow download mulitple backing images with one click and move clean up action in detail modal #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: andy.lee <[email protected]>
Signed-off-by: andy.lee <[email protected]>
a110605
commented
May 20, 2024
| // eslint-disable-next-line no-underscore-dangle | ||
| const downloadUrl = `${window.__pathname_prefix__}${window.__pathname_prefix__.endsWith('/') ? '' : '/'}v1/backingimages/${image.name}/download` | ||
| // specific way to download multiple files with one click, User may allow the browser to download multiple files at once | ||
| Object.assign(document.createElement('a'), { href: downloadUrl, download: image.name }).click() |
There was a problem hiding this comment.
Current backing image download API only supports download one image at a time
v1/backingimages/${params.name}/download
This workaround is to create multiple download links and click them, but need user to give browser permission to do that. So I add a note in modal to let user know
The better approach is to zip the selected image from backend and has a new API to download that zip file. This is also how dropbox and google drive support download multiple files. cc @ChanYiLin
|
LGTM, thanks! |
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Issue
longhorn/longhorn#7293
Result
Sort the backing image list
Bulk download : only has ready disk status image can be downloaded
Move cleanup action in detail modal
