Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backing image clean up action according to latest UI change #913

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Update backing image clean up action according to latest UI change #913

merged 4 commits into from
Jun 3, 2024

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented May 27, 2024 •
edited
Loading

Which issue(s) this PR fixes:

[IMPROVEMENT] BackingImage UI improvement

Issue #
[IMPROVEMENT] BackingImage UI improvement

What this PR does / why we need it:

Before fix
Screenshot 2024-05-27 at 12 00 16 PM

After fix
image

@a110605 a110605 requested a review from a team as a code owner May 27, 2024 04:17
@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit 910bc35
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/665d40a4d771710008a3df6a
😎 Deploy Preview https://deploy-preview-913--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@a110605 a110605 changed the title Update backing image clean up action according to latest change Update backing image clean up action according to latest UI change May 27, 2024
@roger-ryao roger-ryao mentioned this pull request May 28, 2024
Closed
7 tasks
@a110605 a110605 force-pushed the 7293_doc branch 2 times, most recently from 2fa0dbe to 38c62f5 Compare May 30, 2024 02:24
jillian-maroket
jillian-maroket reviewed May 30, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unused backing images can be also cleaned up manually via the Longhorn UI: Click Setting > Backing Image > one backing image name. Then choose disks to clean up.

@a110605 Please provide a screenshot so I can better describe the expected user behavior.

@a110605
Copy link
Contributor Author

a110605 commented May 31, 2024 •
edited
Loading

The unused backing images can be also cleaned up manually via the Longhorn UI: Click Setting > Backing Image > one backing image name. Then choose disks to clean up.

@a110605 Please provide a screenshot so I can better describe the expected user behavior.

@jillian-maroket See the third screenshot recording (Move cleanup action in detail modal) in my PR : longhorn/longhorn-ui#729

jillian-maroket
jillian-maroket reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a110605 Thanks for the link to the recording. I rewrote the instructions based on the UI flow.

content/docs/1.6.3/advanced-resources/backing-image/backing-image.md Outdated Show resolved Hide resolved
content/docs/1.7.0/advanced-resources/backing-image/backing-image.md Outdated Show resolved Hide resolved
@jillian-maroket
Copy link
Contributor

@a110605 By the way, the confirmation message on the UI is missing some words. It should be updated to "Are you sure you want to...".

@a110605
Copy link
Contributor Author

a110605 commented Jun 3, 2024 •
edited
Loading

Are you sure you want to...

@a110605 By the way, the confirmation message on the UI is missing some words. It should be updated to "Are you sure you want to...".

Opened a PR to update the wording and modal style for clean up action.
longhorn/longhorn-ui#738

@a110605 a110605 mentioned this pull request Jun 3, 2024
Merged
jillian-maroket
jillian-maroket approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@innobead innobead requested a review from ChanYiLin June 3, 2024 06:30
@innobead
Copy link
Member

innobead commented Jun 3, 2024

Added @ChanYiLin for review as he is the feature owner.

ChanYiLin
ChanYiLin approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@ChanYiLin ChanYiLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChanYiLin
Copy link
Contributor

ChanYiLin commented Jun 3, 2024 •
edited
Loading

Approved, lets merge it
cc @innobead

@innobead innobead merged commit 13edb5e into longhorn:master Jun 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillian-maroket jillian-maroket jillian-maroket approved these changes

@ChanYiLin ChanYiLin ChanYiLin approved these changes

@innobead innobead innobead approved these changes

Assignees

@a110605 a110605

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a110605 @jillian-maroket @innobead @ChanYiLin