refactor(negative): replace robot test variable assignments with runtime queries #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
refactor-negative-variable-list
branch
16 times, most recently
from
69897d2 to
40fb6da
Compare
c3y1huang
force-pushed
the
refactor-negative-variable-list
branch
7 times, most recently
from
6cc1209 to
8569a38
Compare
c3y1huang
force-pushed
the
refactor-negative-variable-list
branch
3 times, most recently
from
773ed11 to
f9d34c7
Compare
roger-ryao
reviewed
Mar 8, 2024
c3y1huang
force-pushed
the
refactor-negative-variable-list
branch
from
f9d34c7 to
3481332
Compare
khushboo-rancher
previously approved these changes
Mar 8, 2024
c3y1huang
force-pushed
the
refactor-negative-variable-list
branch
from
3481332 to
74d1360
Compare
c3y1huang
force-pushed
the
refactor-negative-variable-list
branch
from
3b6dbf2 to
649132d
Compare
Signed-off-by: Chin-Ya Huang <[email protected]>
Signed-off-by: Chin-Ya Huang <[email protected]>
Signed-off-by: Chin-Ya Huang <[email protected]>
Signed-off-by: Chin-Ya Huang <[email protected]>
Signed-off-by: Chin-Ya Huang <[email protected]>
Signed-off-by: Chin-Ya Huang <[email protected]>
- Removed unnessary try and exception - Removed unnessary variable assignments - Improved logging Signed-off-by: Chin-Ya Huang <[email protected]>
Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-7034 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-7034 Signed-off-by: Chin-Ya Huang <[email protected]>
longhorn/longhorn-7034 Signed-off-by: Chin-Ya Huang <[email protected]>
c3y1huang
force-pushed
the
refactor-negative-variable-list
branch
from
649132d to
a868979
Compare
Signed-off-by: Chin-Ya Huang <[email protected]>
innobead
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longhorn/longhorn#7034