feat(rwx): add rwx nfsOptions to robot test scaffolding. #1690
Conversation
Signed-off-by: James Munson <[email protected]>
|
@james-munson That's great to see team members contribute to negative testing code. Many thanks for the active involvement! It's greatly appreciated! Currently PRs for negative testing are blocked by the refactoring PR. I'll try to merge this once the refactoring PR is done.
I'll try to test locally when I'm available. |
| @@ -23,6 +23,8 @@ def get_name_suffix(*args): | |||
| def create_storageclass(name): | |||
| if name == 'longhorn-test-strict-local': | |||
| filepath = "./templates/workload/strict_local_storageclass.yaml" | |||
| elif name == 'longhorn-test-nfs-options': | |||
| filepath = "./templates/workload/storageclass-nfs-options.yaml" | |||
There was a problem hiding this comment.
Tested based on #1805.
storageclass-nfs-options.yaml should be storageclass_nfs_options.yaml.
Others LGTM.
There was a problem hiding this comment.
I'll make that change, thanks!. Hopefully I can run this myself from Jenkins?
There was a problem hiding this comment.
Yes, we can run customized e2e tests by building images by yourself now, but since e2e test has been refactored by #1604, it is possible that you need to make extra changes to make things work.
|
This pull request is now in conflict. Could you fix it @james-munson? 🙏 |
1 similar comment
|
This pull request is now in conflict. Could you fix it @james-munson? 🙏 |
|
I've created a refined PR, so close this one in favor of it. cc @james-munson |
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#7639
What this PR does / why we need it:
This is a draft for adding a new storage class and rwx volume with overridden mount options to an
e2etest.Special notes for your reviewer:
Untested - hope to test locally or when the pipeline can be triggered with a private build of longhorn-tests. Just checking to see that this is the way it would be done.
Additional documentation or context